mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
net/garp: fix GID rbtree ordering
The comparison operators were backwards in both garp_attr_lookup and garp_attr_create, so the entire GID rbtree was in reverse order. (There was no practical side effect to this though, except that PDUs were sent with attributes listed in reverse order, which is still valid by the protocol. This change is only for clarity.) Signed-off-by: David Ward <david.ward@ll.mit.edu> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
9d02daf754
commit
6f66cdc3e5
|
@ -157,9 +157,9 @@ static struct garp_attr *garp_attr_lookup(const struct garp_applicant *app,
|
|||
while (parent) {
|
||||
attr = rb_entry(parent, struct garp_attr, node);
|
||||
d = garp_attr_cmp(attr, data, len, type);
|
||||
if (d < 0)
|
||||
if (d > 0)
|
||||
parent = parent->rb_left;
|
||||
else if (d > 0)
|
||||
else if (d < 0)
|
||||
parent = parent->rb_right;
|
||||
else
|
||||
return attr;
|
||||
|
@ -178,9 +178,9 @@ static struct garp_attr *garp_attr_create(struct garp_applicant *app,
|
|||
parent = *p;
|
||||
attr = rb_entry(parent, struct garp_attr, node);
|
||||
d = garp_attr_cmp(attr, data, len, type);
|
||||
if (d < 0)
|
||||
if (d > 0)
|
||||
p = &parent->rb_left;
|
||||
else if (d > 0)
|
||||
else if (d < 0)
|
||||
p = &parent->rb_right;
|
||||
else {
|
||||
/* The attribute already exists; re-use it. */
|
||||
|
|
Loading…
Reference in a new issue