system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-29 16:00:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

leds: leds-lp5569: Convert to sysfs_emit API

Browse source 
Convert sprintf to the much safer sysfs_emit API to handle output for
sysfs.

Also better handle situation where on the same chip there may be LED
open and shorted at the same time.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: https://lore.kernel.org/r/20240626221520.2846-1-ansuelsmth@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Christian Marangi 2024-06-27 00:15:11 +02:00 committed by Lee Jones
parent 940b27161a
commit 6f2fdde909
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/leds/leds-lp5569.c
View file

@ -268,8 +268,8 @@ static ssize_t lp5569_led_open_test(struct lp55xx_led *led, char *buf)
led_tmp = led;
for (i = 0; i < pdata->num_channels; i++) {
if (leds_fault[led_tmp->chan_nr])
pos += sprintf(buf + pos, "LED %d OPEN FAIL\n",
led_tmp->chan_nr);
pos += sysfs_emit_at(buf, pos, "LED %d OPEN FAIL\n",
led_tmp->chan_nr);
led_tmp++;
}
@ -366,8 +366,8 @@ static ssize_t lp5569_led_short_test(struct lp55xx_led *led, char *buf)
led_tmp = led;
for (i = 0; i < pdata->num_channels; i++) {
if (leds_fault[led_tmp->chan_nr])
pos += sprintf(buf + pos, "LED %d SHORTED FAIL\n",
led_tmp->chan_nr);
pos += sysfs_emit_at(buf, pos, "LED %d SHORTED FAIL\n",
led_tmp->chan_nr);
led_tmp++;
}
@ -404,7 +404,7 @@ static ssize_t lp5569_selftest(struct device *dev,
goto fail;
/* Test LED Shorted */
pos = lp5569_led_short_test(led, buf);
pos += lp5569_led_short_test(led, buf);
if (pos < 0)
goto fail;
@ -420,10 +420,10 @@ static ssize_t lp5569_selftest(struct device *dev,
}
if (pos == 0)
pos = sprintf(buf, "OK\n");
pos = sysfs_emit(buf, "OK\n");
goto release_lock;
fail:
pos = sprintf(buf, "FAIL\n");
pos = sysfs_emit(buf, "FAIL\n");
release_lock:
mutex_unlock(&chip->lock);