system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-08 04:12:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

scsi: 53c700: Call scsi_done() directly

Browse source 
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-12-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche 2021-10-07 13:28:06 -07:00 committed by Martin K. Petersen
parent 9dd9b96c26
commit 656f26ade0
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/scsi/53c700.c
View file

@ -634,7 +634,7 @@ NCR_700_scsi_done(struct NCR_700_Host_Parameters *hostdata,
SCp->host_scribble = NULL; SCp->host_scribble = NULL;
SCp->result = result; SCp->result = result;
SCp->scsi_done(SCp); scsi_done(SCp);
} else { } else {
printk(KERN_ERR "53c700: SCSI DONE HAS NULL SCp\n"); printk(KERN_ERR "53c700: SCSI DONE HAS NULL SCp\n");
} }
@ -1571,7 +1571,7 @@ NCR_700_intr(int irq, void *dev_id)
* deadlock on the * deadlock on the
* hostdata->state_lock */ * hostdata->state_lock */
SCp->result = DID_RESET << 16; SCp->result = DID_RESET << 16;
SCp->scsi_done(SCp); scsi_done(SCp);
} }
mdelay(25); mdelay(25);
NCR_700_chip_setup(host); NCR_700_chip_setup(host);
@ -1792,7 +1792,6 @@ NCR_700_queuecommand_lck(struct scsi_cmnd *SCp, void (*done)(struct scsi_cmnd *)
slot->cmnd = SCp; slot->cmnd = SCp;
SCp->scsi_done = done;
SCp->host_scribble = (unsigned char *)slot; SCp->host_scribble = (unsigned char *)slot;
SCp->SCp.ptr = NULL; SCp->SCp.ptr = NULL;
SCp->SCp.buffer = NULL; SCp->SCp.buffer = NULL;