system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-04 10:26:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

USB: gadget: u_ether: Fix a configfs return code

Browse source 
If the string is invalid, this should return -EINVAL instead of 0.

Fixes: 73517cf49b ("usb: gadget: add RNDIS configfs options for class/subclass/protocol")
Cc: stable <stable@vger.kernel.org>
Acked-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YCqZ3P53yyIg5cn7@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2021-02-15 15:57:16 +00:00 committed by Greg Kroah-Hartman
parent 1edbff9c80
commit 650bf52208
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/usb/gadget/function/u_ether_configfs.h
View file

@ -182,12 +182,11 @@ out: \
size_t len) \ size_t len) \
{ \ { \
struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \ struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
int ret; \ int ret = -EINVAL; \
u8 val; \ u8 val; \
\ \
mutex_lock(&opts->lock); \ mutex_lock(&opts->lock); \
ret = sscanf(page, "%02hhx", &val); \ if (sscanf(page, "%02hhx", &val) > 0) { \
if (ret > 0) { \
opts->_n_ = val; \ opts->_n_ = val; \
ret = len; \ ret = len; \
} \ } \