mirror of
https://github.com/torvalds/linux
synced 2024-10-15 07:47:34 +00:00
net: ipv4: fix a memleak in ip_setup_cork
When inetdev_valid_mtu fails, cork->opt should be freed if it is
allocated in ip_setup_cork. Otherwise there could be a memleak.
Fixes: 501a90c945
("inet: protect against too small mtu values.")
Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240129091017.2938835-1-alexious@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
e028243003
commit
5dee6d6923
|
@ -1287,6 +1287,12 @@ static int ip_setup_cork(struct sock *sk, struct inet_cork *cork,
|
||||||
if (unlikely(!rt))
|
if (unlikely(!rt))
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
|
|
||||||
|
cork->fragsize = ip_sk_use_pmtu(sk) ?
|
||||||
|
dst_mtu(&rt->dst) : READ_ONCE(rt->dst.dev->mtu);
|
||||||
|
|
||||||
|
if (!inetdev_valid_mtu(cork->fragsize))
|
||||||
|
return -ENETUNREACH;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* setup for corking.
|
* setup for corking.
|
||||||
*/
|
*/
|
||||||
|
@ -1303,12 +1309,6 @@ static int ip_setup_cork(struct sock *sk, struct inet_cork *cork,
|
||||||
cork->addr = ipc->addr;
|
cork->addr = ipc->addr;
|
||||||
}
|
}
|
||||||
|
|
||||||
cork->fragsize = ip_sk_use_pmtu(sk) ?
|
|
||||||
dst_mtu(&rt->dst) : READ_ONCE(rt->dst.dev->mtu);
|
|
||||||
|
|
||||||
if (!inetdev_valid_mtu(cork->fragsize))
|
|
||||||
return -ENETUNREACH;
|
|
||||||
|
|
||||||
cork->gso_size = ipc->gso_size;
|
cork->gso_size = ipc->gso_size;
|
||||||
|
|
||||||
cork->dst = &rt->dst;
|
cork->dst = &rt->dst;
|
||||||
|
|
Loading…
Reference in a new issue