system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-20 02:57:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

mfd: atmel-flexcom: Use .resume_noirq

Browse source 
Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation
mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might
be connected critical devices (like PMIC) which on suspend/resume should
be suspended/resumed at the end/beginning. i2c uses
.suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom
to use .resume_noirq as it should be resumed before the embedded IPs.
Otherwise the embedded devices might behave badly.

Fixes: 7fdec11015 ("atmel_flexcom: Support resuming after a chip reset")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211028135138.3481166-3-claudiu.beznea@microchip.com
This commit is contained in:
Claudiu Beznea 2021-10-28 16:51:38 +03:00 committed by Lee Jones
parent 8c0fad75dc
commit 5d051cf94f
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/mfd/atmel-flexcom.c
View file

@ -87,7 +87,7 @@ static const struct of_device_id atmel_flexcom_of_match[] = {
}; };
MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match); MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
static int __maybe_unused atmel_flexcom_resume(struct device *dev) static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
{ {
struct atmel_flexcom *ddata = dev_get_drvdata(dev); struct atmel_flexcom *ddata = dev_get_drvdata(dev);
int err; int err;
@ -105,8 +105,9 @@ static int __maybe_unused atmel_flexcom_resume(struct device *dev)
return 0; return 0;
} }
static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL, static const struct dev_pm_ops atmel_flexcom_pm_ops = {
atmel_flexcom_resume); .resume_noirq = atmel_flexcom_resume_noirq,
};
static struct platform_driver atmel_flexcom_driver = { static struct platform_driver atmel_flexcom_driver = {
.probe = atmel_flexcom_probe, .probe = atmel_flexcom_probe,