system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-25 20:59:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: usbdux: tidy up usbdux_pwm_write()

Browse source 
Remove the sanity check of the private data. This function can only be
called if the private data was successfully allocated in the attach.

Tidy up the function a bit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2013-07-29 17:44:50 -07:00 committed by Greg Kroah-Hartman
parent 3b2dc08b72
commit 5c63f094a7
1 changed files with 13 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
drivers/staging/comedi/drivers/usbdux.c
View file

@ -1426,27 +1426,23 @@ static int usbdux_pwm_pattern(struct comedi_device *dev,
static int usbdux_pwm_write(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
struct comedi_insn *insn,
unsigned int *data)
{
struct usbdux_private *this_usbduxsub = dev->private;
unsigned int chan = CR_CHAN(insn->chanspec);
if (!this_usbduxsub)
return -EFAULT;
if ((insn->n) != 1) {
/*
* doesn't make sense to have more than one value here because
* it would just overwrite the PWM buffer a couple of times
* It doesn't make sense to support more than one value here
* because it would just overwrite the PWM buffer.
*/
if (insn->n != 1)
return -EINVAL;
}
/*
* the sign is set via a special INSN only, this gives us 8 bits for
* normal operation
* relay sign 0 by default
* The sign is set via a special INSN only, this gives us 8 bits
* for normal operation, sign is 0 by default.
*/
return usbdux_pwm_pattern(dev, s, CR_CHAN(insn->chanspec), data[0], 0);
return usbdux_pwm_pattern(dev, s, chan, data[0], 0);
}
static int usbdux_pwm_read(struct comedi_device *x1,