mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
watchdog: sama5d4_wdt: Remove #ifdef guards for PM related functions
Use the new LATE_SYSTEM_SLEEP_PM_OPS() and pm_sleep_ptr() macros to handle the .suspend/.resume callbacks. These macros allow the suspend and resume functions to be automatically dropped by the compiler when CONFIG_SUSPEND is disabled, without having to use #ifdef guards. Not using #ifdef guards means that the code is always compiled independently of any Kconfig option, and thanks to that bugs and regressions are easier to catch. Signed-off-by: Paul Cercueil <paul@crapouillou.net> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Claudiu Beznea <claudiu.beznea@microchip.com> Cc: linux-arm-kernel@lists.infradead.org Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20220628193449.160585-6-paul@crapouillou.net Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
This commit is contained in:
parent
aa55761ab4
commit
5c040ea210
|
@ -339,7 +339,6 @@ static const struct of_device_id sama5d4_wdt_of_match[] = {
|
|||
};
|
||||
MODULE_DEVICE_TABLE(of, sama5d4_wdt_of_match);
|
||||
|
||||
#ifdef CONFIG_PM_SLEEP
|
||||
static int sama5d4_wdt_suspend_late(struct device *dev)
|
||||
{
|
||||
struct sama5d4_wdt *wdt = dev_get_drvdata(dev);
|
||||
|
@ -366,18 +365,17 @@ static int sama5d4_wdt_resume_early(struct device *dev)
|
|||
|
||||
return 0;
|
||||
}
|
||||
#endif
|
||||
|
||||
static const struct dev_pm_ops sama5d4_wdt_pm_ops = {
|
||||
SET_LATE_SYSTEM_SLEEP_PM_OPS(sama5d4_wdt_suspend_late,
|
||||
sama5d4_wdt_resume_early)
|
||||
LATE_SYSTEM_SLEEP_PM_OPS(sama5d4_wdt_suspend_late,
|
||||
sama5d4_wdt_resume_early)
|
||||
};
|
||||
|
||||
static struct platform_driver sama5d4_wdt_driver = {
|
||||
.probe = sama5d4_wdt_probe,
|
||||
.driver = {
|
||||
.name = "sama5d4_wdt",
|
||||
.pm = &sama5d4_wdt_pm_ops,
|
||||
.pm = pm_sleep_ptr(&sama5d4_wdt_pm_ops),
|
||||
.of_match_table = sama5d4_wdt_of_match,
|
||||
}
|
||||
};
|
||||
|
|
Loading…
Reference in a new issue