mirror of
https://github.com/torvalds/linux
synced 2024-10-04 18:33:42 +00:00
MIPS: Alchemy: Use kcalloc() instead of kzalloc()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function. Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1] Link: https://github.com/KSPP/linux/issues/162 Signed-off-by: Erick Archer <erick.archer@gmx.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
This commit is contained in:
parent
e34813c2da
commit
5b7236c198
|
@ -771,7 +771,7 @@ static int __init alchemy_clk_init_fgens(int ctype)
|
||||||
}
|
}
|
||||||
id.flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE;
|
id.flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE;
|
||||||
|
|
||||||
a = kzalloc((sizeof(*a)) * 6, GFP_KERNEL);
|
a = kcalloc(6, sizeof(*a), GFP_KERNEL);
|
||||||
if (!a)
|
if (!a)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue