mirror of
https://github.com/torvalds/linux
synced 2024-10-07 20:05:15 +00:00
mmc: sdhci-of-dwcmshc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Yangtao Li <frank.li@vivo.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Link: https://lore.kernel.org/r/20230727070051.17778-26-frank.li@vivo.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
parent
3de205a07a
commit
5905a1f1f2
|
@ -574,7 +574,7 @@ static int dwcmshc_probe(struct platform_device *pdev)
|
|||
return err;
|
||||
}
|
||||
|
||||
static int dwcmshc_remove(struct platform_device *pdev)
|
||||
static void dwcmshc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct sdhci_host *host = platform_get_drvdata(pdev);
|
||||
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
|
||||
|
@ -589,8 +589,6 @@ static int dwcmshc_remove(struct platform_device *pdev)
|
|||
clk_bulk_disable_unprepare(RK35xx_MAX_CLKS,
|
||||
rk_priv->rockchip_clks);
|
||||
sdhci_pltfm_free(pdev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM_SLEEP
|
||||
|
@ -657,7 +655,7 @@ static struct platform_driver sdhci_dwcmshc_driver = {
|
|||
.pm = &dwcmshc_pmops,
|
||||
},
|
||||
.probe = dwcmshc_probe,
|
||||
.remove = dwcmshc_remove,
|
||||
.remove_new = dwcmshc_remove,
|
||||
};
|
||||
module_platform_driver(sdhci_dwcmshc_driver);
|
||||
|
||||
|
|
Loading…
Reference in a new issue