mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
batman-adv: prefer kfree_rcu() over call_rcu() with free-only callbacks
Drop 'batadv_tt_local_entry_free_rcu()', 'batadv_tt_global_entry_free_rcu()' and 'batadv_tt_orig_list_entry_free_rcu()' in favor of 'kfree_rcu()' in 'batadv_tt_local_entry_release()', 'batadv_tt_global_entry_release()' and 'batadv_tt_orig_list_entry_release()', respectively. Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Acked-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
This commit is contained in:
parent
3ae5cb7efa
commit
537db05da2
|
@ -208,20 +208,6 @@ batadv_tt_global_hash_find(struct batadv_priv *bat_priv, const u8 *addr,
|
||||||
return tt_global_entry;
|
return tt_global_entry;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* batadv_tt_local_entry_free_rcu() - free the tt_local_entry
|
|
||||||
* @rcu: rcu pointer of the tt_local_entry
|
|
||||||
*/
|
|
||||||
static void batadv_tt_local_entry_free_rcu(struct rcu_head *rcu)
|
|
||||||
{
|
|
||||||
struct batadv_tt_local_entry *tt_local_entry;
|
|
||||||
|
|
||||||
tt_local_entry = container_of(rcu, struct batadv_tt_local_entry,
|
|
||||||
common.rcu);
|
|
||||||
|
|
||||||
kmem_cache_free(batadv_tl_cache, tt_local_entry);
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* batadv_tt_local_entry_release() - release tt_local_entry from lists and queue
|
* batadv_tt_local_entry_release() - release tt_local_entry from lists and queue
|
||||||
* for free after rcu grace period
|
* for free after rcu grace period
|
||||||
|
@ -236,7 +222,7 @@ static void batadv_tt_local_entry_release(struct kref *ref)
|
||||||
|
|
||||||
batadv_softif_vlan_put(tt_local_entry->vlan);
|
batadv_softif_vlan_put(tt_local_entry->vlan);
|
||||||
|
|
||||||
call_rcu(&tt_local_entry->common.rcu, batadv_tt_local_entry_free_rcu);
|
kfree_rcu(tt_local_entry, common.rcu);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -254,20 +240,6 @@ batadv_tt_local_entry_put(struct batadv_tt_local_entry *tt_local_entry)
|
||||||
batadv_tt_local_entry_release);
|
batadv_tt_local_entry_release);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* batadv_tt_global_entry_free_rcu() - free the tt_global_entry
|
|
||||||
* @rcu: rcu pointer of the tt_global_entry
|
|
||||||
*/
|
|
||||||
static void batadv_tt_global_entry_free_rcu(struct rcu_head *rcu)
|
|
||||||
{
|
|
||||||
struct batadv_tt_global_entry *tt_global_entry;
|
|
||||||
|
|
||||||
tt_global_entry = container_of(rcu, struct batadv_tt_global_entry,
|
|
||||||
common.rcu);
|
|
||||||
|
|
||||||
kmem_cache_free(batadv_tg_cache, tt_global_entry);
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* batadv_tt_global_entry_release() - release tt_global_entry from lists and
|
* batadv_tt_global_entry_release() - release tt_global_entry from lists and
|
||||||
* queue for free after rcu grace period
|
* queue for free after rcu grace period
|
||||||
|
@ -282,7 +254,7 @@ void batadv_tt_global_entry_release(struct kref *ref)
|
||||||
|
|
||||||
batadv_tt_global_del_orig_list(tt_global_entry);
|
batadv_tt_global_del_orig_list(tt_global_entry);
|
||||||
|
|
||||||
call_rcu(&tt_global_entry->common.rcu, batadv_tt_global_entry_free_rcu);
|
kfree_rcu(tt_global_entry, common.rcu);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -407,19 +379,6 @@ static void batadv_tt_global_size_dec(struct batadv_orig_node *orig_node,
|
||||||
batadv_tt_global_size_mod(orig_node, vid, -1);
|
batadv_tt_global_size_mod(orig_node, vid, -1);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* batadv_tt_orig_list_entry_free_rcu() - free the orig_entry
|
|
||||||
* @rcu: rcu pointer of the orig_entry
|
|
||||||
*/
|
|
||||||
static void batadv_tt_orig_list_entry_free_rcu(struct rcu_head *rcu)
|
|
||||||
{
|
|
||||||
struct batadv_tt_orig_list_entry *orig_entry;
|
|
||||||
|
|
||||||
orig_entry = container_of(rcu, struct batadv_tt_orig_list_entry, rcu);
|
|
||||||
|
|
||||||
kmem_cache_free(batadv_tt_orig_cache, orig_entry);
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* batadv_tt_orig_list_entry_release() - release tt orig entry from lists and
|
* batadv_tt_orig_list_entry_release() - release tt orig entry from lists and
|
||||||
* queue for free after rcu grace period
|
* queue for free after rcu grace period
|
||||||
|
@ -433,7 +392,7 @@ static void batadv_tt_orig_list_entry_release(struct kref *ref)
|
||||||
refcount);
|
refcount);
|
||||||
|
|
||||||
batadv_orig_node_put(orig_entry->orig_node);
|
batadv_orig_node_put(orig_entry->orig_node);
|
||||||
call_rcu(&orig_entry->rcu, batadv_tt_orig_list_entry_free_rcu);
|
kfree_rcu(orig_entry, rcu);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in a new issue