system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-06 09:51:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf/arm-cmn: Workaround AmpereOneX errata AC04_MESH_1 (incorrect child count)

Browse source 
AmpereOneX mesh implementation has a bug in HN-P nodes that makes them
report incorrect child count. The failing crosspoints report 8 children
while they only have two.

When the driver tries to access the inexistent child nodes, it believes it
has reached an invalid node type and probing fails. The workaround is to
ignore those incorrect child nodes and continue normally.

Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
[ rm: rewrote simpler generalised version ]
Tested-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/ce4b1442135fe03d0de41859b04b268c88c854a3.1707498577.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
This commit is contained in:
Ilkka Koskinen 2024-02-09 17:11:09 +00:00 committed by Will Deacon
parent f9daab0ad0
commit 50572064ec
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/perf/arm-cmn.c
View file

@ -2305,6 +2305,17 @@ static int arm_cmn_discover(struct arm_cmn *cmn, unsigned int rgn_offset)
dev_dbg(cmn->dev, "ignoring external node %llx\n", reg);
continue;
}
/*
* AmpereOneX erratum AC04_MESH_1 makes some XPs report a bogus
* child count larger than the number of valid child pointers.
* A child offset of 0 can only occur on CMN-600; otherwise it
* would imply the root node being its own grandchild, which
* we can safely dismiss in general.
*/
if (reg == 0 && cmn->part != PART_CMN600) {
dev_dbg(cmn->dev, "bogus child pointer?\n");
continue;
}
arm_cmn_init_node_info(cmn, reg & CMN_CHILD_NODE_ADDR, dn);