system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-29 16:00:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: meson: axg-fifo: fix irq scheduling issue with PREEMPT_RT

Browse source 
With PREEMPT_RT enabled a spinlock_t becomes a sleeping lock.

This is usually not a problem with spinlocks used in IRQ context since
IRQ handlers get threaded. However, if IRQF_ONESHOT is set, the primary
handler won't be force-threaded and runs always in hardirq context. This is
a problem because spinlock_t requires a preemptible context on PREEMPT_RT.

In this particular instance, regmap mmio uses spinlock_t to protect the
register access and IRQF_ONESHOT is set on the IRQ. In this case, it is
actually better to do everything in threaded handler and it solves the
problem with PREEMPT_RT.

Reported-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
Closes: https://lore.kernel.org/linux-amlogic/20240729131652.3012327-1-avkrasnov@salutedevices.com
Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Fixes: b11d26660d ("ASoC: meson: axg-fifo: use threaded irq to check periods")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20240807162705.4024136-1-jbrunet@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Jerome Brunet 2024-08-07 18:27:03 +02:00 committed by Mark Brown
parent 2f11f61f9d
commit 5003d0ce5c
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 10 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
sound/soc/meson/axg-fifo.c
View file

@ -207,25 +207,18 @@ static irqreturn_t axg_fifo_pcm_irq_block(int irq, void *dev_id)
status = FIELD_GET(STATUS1_INT_STS, status); status = FIELD_GET(STATUS1_INT_STS, status);
axg_fifo_ack_irq(fifo, status); axg_fifo_ack_irq(fifo, status);
/* Use the thread to call period elapsed on nonatomic links */ if (status & ~FIFO_INT_COUNT_REPEAT)
if (status & FIFO_INT_COUNT_REPEAT) dev_dbg(axg_fifo_dev(ss), "unexpected irq - STS 0x%02x\n",
return IRQ_WAKE_THREAD; status);
dev_dbg(axg_fifo_dev(ss), "unexpected irq - STS 0x%02x\n", if (status & FIFO_INT_COUNT_REPEAT) {
status); snd_pcm_period_elapsed(ss);
return IRQ_HANDLED;
}
return IRQ_NONE; return IRQ_NONE;
} }
static irqreturn_t axg_fifo_pcm_irq_block_thread(int irq, void *dev_id)
{
struct snd_pcm_substream *ss = dev_id;
snd_pcm_period_elapsed(ss);
return IRQ_HANDLED;
}
int axg_fifo_pcm_open(struct snd_soc_component *component, int axg_fifo_pcm_open(struct snd_soc_component *component,
struct snd_pcm_substream *ss) struct snd_pcm_substream *ss)
{ {
@ -251,8 +244,9 @@ int axg_fifo_pcm_open(struct snd_soc_component *component,
if (ret) if (ret)
return ret; return ret;
ret = request_threaded_irq(fifo->irq, axg_fifo_pcm_irq_block, /* Use the threaded irq handler only with non-atomic links */
axg_fifo_pcm_irq_block_thread, ret = request_threaded_irq(fifo->irq, NULL,
axg_fifo_pcm_irq_block,
IRQF_ONESHOT, dev_name(dev), ss); IRQF_ONESHOT, dev_name(dev), ss);
if (ret) if (ret)
return ret; return ret;