system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-11-05 18:23:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

perf config: Check error cases of {show_spec, set}_config()

Browse source 
show_spec_config() and set_config() can be called multiple times
in the loop in cmd_config().

However, The error cases of them wasn't checked, so fix it.

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1497671197-20450-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Taeung Song 2017-06-17 12:46:37 +09:00 committed by Arnaldo Carvalho de Melo
parent 1096c35aa8
commit 4f1fd74283
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
tools/perf/builtin-config.c
View file

@ -225,10 +225,23 @@ int cmd_config(int argc, const char **argv)
break;
}
if (value == NULL)
if (value == NULL) {
ret = show_spec_config(set, var);
else
if (ret < 0) {
pr_err("%s is not configured: %s\n",
var, config_filename);
free(arg);
break;
}
} else {
ret = set_config(set, config_filename, var, value);
if (ret < 0) {
pr_err("Failed to set '%s=%s' on %s\n",
var, value, config_filename);
free(arg);
break;
}
}
free(arg);
}
}