system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-22 03:55:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

silently ignore ownership changes unless unix extensions are enabled or we're faking uid changes

Browse source 
CIFS currently allows you to change the ownership of a file, but unless
unix extensions are enabled this change is not passed off to the server.

Have CIFS silently ignore ownership changes that can't be persistently
stored on the server unless the "setuids" option is explicitly
specified.

We could return an error here (-EOPNOTSUPP or something), but this is
how most disk-based windows filesystems on behave on Linux (e.g.  VFAT,
NTFS, etc). With cifsacl support and proper Windows to Unix idmapping
support, we may be able to do this more properly in the future.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
This commit is contained in:
Jeff Layton 2008-05-22 09:33:34 -04:00 committed by Steve French
parent 4e94a105ed
commit 4ca691a892
1 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
fs/cifs/inode.c
View file

@ -1546,13 +1546,26 @@ int cifs_setattr(struct dentry *direntry, struct iattr *attrs)
} else } else
goto cifs_setattr_exit; goto cifs_setattr_exit;
} }
if (attrs->ia_valid & ATTR_UID) {
cFYI(1, ("UID changed to %d", attrs->ia_uid)); /*
uid = attrs->ia_uid; * Without unix extensions we can't send ownership changes to the
} * server, so silently ignore them. This is consistent with how
if (attrs->ia_valid & ATTR_GID) { * local DOS/Windows filesystems behave (VFAT, NTFS, etc). With
cFYI(1, ("GID changed to %d", attrs->ia_gid)); * CIFSACL support + proper Windows to Unix idmapping, we may be
gid = attrs->ia_gid; * able to support this in the future.
*/
if (!pTcon->unix_ext &&
!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_SET_UID)) {
attrs->ia_valid &= ~(ATTR_UID | ATTR_GID);
} else {
if (attrs->ia_valid & ATTR_UID) {
cFYI(1, ("UID changed to %d", attrs->ia_uid));
uid = attrs->ia_uid;
}
if (attrs->ia_valid & ATTR_GID) {
cFYI(1, ("GID changed to %d", attrs->ia_gid));
gid = attrs->ia_gid;
}
} }
time_buf.Attributes = 0; time_buf.Attributes = 0;