mirror of
https://github.com/torvalds/linux
synced 2024-09-16 00:58:07 +00:00
ALSA: ump: Fix the discard error code from snd_ump_legacy_open()
snd_ump_legacy_open() didn't return the error code properly even if it
couldn't open. Fix it.
Fixes: 0b5288f5fe
("ALSA: ump: Add legacy raw MIDI support")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20240220150843.28630-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
1fdf4e8be7
commit
49cbb7b7d3
|
@ -985,7 +985,7 @@ static int snd_ump_legacy_open(struct snd_rawmidi_substream *substream)
|
|||
struct snd_ump_endpoint *ump = substream->rmidi->private_data;
|
||||
int dir = substream->stream;
|
||||
int group = ump->legacy_mapping[substream->number];
|
||||
int err;
|
||||
int err = 0;
|
||||
|
||||
mutex_lock(&ump->open_mutex);
|
||||
if (ump->legacy_substreams[dir][group]) {
|
||||
|
@ -1009,7 +1009,7 @@ static int snd_ump_legacy_open(struct snd_rawmidi_substream *substream)
|
|||
spin_unlock_irq(&ump->legacy_locks[dir]);
|
||||
unlock:
|
||||
mutex_unlock(&ump->open_mutex);
|
||||
return 0;
|
||||
return err;
|
||||
}
|
||||
|
||||
static int snd_ump_legacy_close(struct snd_rawmidi_substream *substream)
|
||||
|
|
Loading…
Reference in a new issue