mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
lib/test_firmware.c: remove some dead code
The test_fw_config->reqs allocation succeeded so these addresses can't be NULL. Also on the second error path, we forgot to set "rc = -ENOMEM;". Link: http://lkml.kernel.org/r/20190221183700.GA1737@kadam Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
76c37f7489
commit
488cf83380
|
@ -631,11 +631,6 @@ static ssize_t trigger_batched_requests_store(struct device *dev,
|
||||||
|
|
||||||
for (i = 0; i < test_fw_config->num_requests; i++) {
|
for (i = 0; i < test_fw_config->num_requests; i++) {
|
||||||
req = &test_fw_config->reqs[i];
|
req = &test_fw_config->reqs[i];
|
||||||
if (!req) {
|
|
||||||
WARN_ON(1);
|
|
||||||
rc = -ENOMEM;
|
|
||||||
goto out_bail;
|
|
||||||
}
|
|
||||||
req->fw = NULL;
|
req->fw = NULL;
|
||||||
req->idx = i;
|
req->idx = i;
|
||||||
req->name = test_fw_config->name;
|
req->name = test_fw_config->name;
|
||||||
|
@ -737,10 +732,6 @@ ssize_t trigger_batched_requests_async_store(struct device *dev,
|
||||||
|
|
||||||
for (i = 0; i < test_fw_config->num_requests; i++) {
|
for (i = 0; i < test_fw_config->num_requests; i++) {
|
||||||
req = &test_fw_config->reqs[i];
|
req = &test_fw_config->reqs[i];
|
||||||
if (!req) {
|
|
||||||
WARN_ON(1);
|
|
||||||
goto out_bail;
|
|
||||||
}
|
|
||||||
req->name = test_fw_config->name;
|
req->name = test_fw_config->name;
|
||||||
req->fw = NULL;
|
req->fw = NULL;
|
||||||
req->idx = i;
|
req->idx = i;
|
||||||
|
|
Loading…
Reference in a new issue