system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-24 05:17:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

drm/i915/dp: promote clock recovery failures to DRM_ERROR

Browse source 
If channel equalization succeeds, there's no indication something went
wrong in clock recovery (unless debug is enabled). We should shout about
the failures and fix them instead of hiding them under the carpet.

This has allowed bugs like [1] stay dormant for a long time.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=70117

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Jani Nikula 2013-10-05 16:13:56 +03:00 committed by Daniel Vetter
parent e1553faa90
commit 3def84b34c
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/gpu/drm/i915/intel_dp.c
View file

@ -2507,7 +2507,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
if (i == intel_dp->lane_count) { if (i == intel_dp->lane_count) {
++loop_tries; ++loop_tries;
if (loop_tries == 5) { if (loop_tries == 5) {
DRM_DEBUG_KMS("too many full retries, give up\n"); DRM_ERROR("too many full retries, give up\n");
break; break;
} }
intel_dp_reset_link_train(intel_dp, &DP, intel_dp_reset_link_train(intel_dp, &DP,
@ -2521,7 +2521,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) { if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) {
++voltage_tries; ++voltage_tries;
if (voltage_tries == 5) { if (voltage_tries == 5) {
DRM_DEBUG_KMS("too many voltage retries, give up\n"); DRM_ERROR("too many voltage retries, give up\n");
break; break;
} }
} else } else