system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-09-06 18:01:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

ASoC: simple-card-utils: Make simple_util_remove() return void

Browse source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code.  However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

simple_util_remove() returned zero unconditionally. Make it return void
instead and convert all users to struct platform_device::remove_new().

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20231013221945.1489203-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-10-14 00:19:50 +02:00 committed by Mark Brown
parent 6b02f5a6f1
commit 393df6f321
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
7 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/sound/simple_card_utils.h
View file

@ -188,7 +188,7 @@ int simple_util_init_aux_jacks(struct simple_util_priv *priv,
char *prefix);
int simple_util_init_priv(struct simple_util_priv *priv,
struct link_info *li);
int simple_util_remove(struct platform_device *pdev);
void simple_util_remove(struct platform_device *pdev);
int graph_util_card_probe(struct snd_soc_card *card);
int graph_util_is_ports0(struct device_node *port);

2
sound/soc/generic/audio-graph-card.c
View file

@ -644,7 +644,7 @@ static struct platform_driver graph_card = {
.of_match_table = graph_of_match,
},
.probe = graph_probe,
.remove = simple_util_remove,
.remove_new = simple_util_remove,
};
module_platform_driver(graph_card);

2
sound/soc/generic/audio-graph-card2-custom-sample.c
View file

@ -176,7 +176,7 @@ static struct platform_driver custom_card = {
.of_match_table = custom_of_match,
},
.probe = custom_probe,
.remove = simple_util_remove,
.remove_new = simple_util_remove,
};
module_platform_driver(custom_card);

2
sound/soc/generic/audio-graph-card2.c
View file

@ -1224,7 +1224,7 @@ static struct platform_driver graph_card = {
.of_match_table = graph_of_match,
},
.probe = graph_probe,
.remove = simple_util_remove,
.remove_new = simple_util_remove,
};
module_platform_driver(graph_card);

4
sound/soc/generic/simple-card-utils.c
View file

@ -958,13 +958,11 @@ int simple_util_init_priv(struct simple_util_priv *priv,
}
EXPORT_SYMBOL_GPL(simple_util_init_priv);
int simple_util_remove(struct platform_device *pdev)
void simple_util_remove(struct platform_device *pdev)
{
struct snd_soc_card *card = platform_get_drvdata(pdev);
simple_util_clean_reference(card);
return 0;
}
EXPORT_SYMBOL_GPL(simple_util_remove);

2
sound/soc/generic/simple-card.c
View file

@ -827,7 +827,7 @@ static struct platform_driver simple_card = {
.of_match_table = simple_of_match,
},
.probe = simple_probe,
.remove = simple_util_remove,
.remove_new = simple_util_remove,
};
module_platform_driver(simple_card);

2
sound/soc/tegra/tegra_audio_graph_card.c
View file

@ -248,7 +248,7 @@ static struct platform_driver tegra_audio_graph_card = {
.of_match_table = graph_of_tegra_match,
},
.probe = tegra_audio_graph_probe,
.remove = simple_util_remove,
.remove_new = simple_util_remove,
};
module_platform_driver(tegra_audio_graph_card);