system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-24 12:17:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: ethernet: ibm: ehea: ehea_qmr.c: Fix for possible null pointer dereference

Browse source 
There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Rickard Strandqvist 2014-05-18 18:01:21 +02:00 committed by David S. Miller
parent 71fd762f2e
commit 38ea4e6e4a
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/ethernet/ibm/ehea/ehea_qmr.c
View file

@ -103,12 +103,14 @@ static int hw_queue_ctor(struct hw_queue *queue, const u32 nr_of_pages,
static void hw_queue_dtor(struct hw_queue *queue) static void hw_queue_dtor(struct hw_queue *queue)
{ {
int pages_per_kpage = PAGE_SIZE / queue->pagesize; int pages_per_kpage;
int i, nr_pages; int i, nr_pages;
if (!queue || !queue->queue_pages) if (!queue || !queue->queue_pages)
return; return;
pages_per_kpage = PAGE_SIZE / queue->pagesize;
nr_pages = queue->queue_length / queue->pagesize; nr_pages = queue->queue_length / queue->pagesize;
for (i = 0; i < nr_pages; i += pages_per_kpage) for (i = 0; i < nr_pages; i += pages_per_kpage)