system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-10-07 20:05:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

mmc: meson-mx-sdhc: Convert to platform remove callback returning void

Browse source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://lore.kernel.org/r/20230727070051.17778-22-frank.li@vivo.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Yangtao Li 2023-07-27 15:00:11 +08:00 committed by Ulf Hansson
parent 444176665f
commit 3372487a4c
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/mmc/host/meson-mx-sdhc-mmc.c
View file

@ -880,7 +880,7 @@ static int meson_mx_sdhc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int meson_mx_sdhc_remove(struct platform_device *pdev) static void meson_mx_sdhc_remove(struct platform_device *pdev)
{ {
struct meson_mx_sdhc_host *host = platform_get_drvdata(pdev); struct meson_mx_sdhc_host *host = platform_get_drvdata(pdev);
@ -889,8 +889,6 @@ static int meson_mx_sdhc_remove(struct platform_device *pdev)
meson_mx_sdhc_disable_clks(host->mmc); meson_mx_sdhc_disable_clks(host->mmc);
clk_disable_unprepare(host->pclk); clk_disable_unprepare(host->pclk);
return 0;
} }
static const struct meson_mx_sdhc_data meson_mx_sdhc_data_meson8 = { static const struct meson_mx_sdhc_data meson_mx_sdhc_data_meson8 = {
@ -925,7 +923,7 @@ MODULE_DEVICE_TABLE(of, meson_mx_sdhc_of_match);
static struct platform_driver meson_mx_sdhc_driver = { static struct platform_driver meson_mx_sdhc_driver = {
.probe = meson_mx_sdhc_probe, .probe = meson_mx_sdhc_probe,
.remove = meson_mx_sdhc_remove, .remove_new = meson_mx_sdhc_remove,
.driver = { .driver = {
.name = "meson-mx-sdhc", .name = "meson-mx-sdhc",
.probe_type = PROBE_PREFER_ASYNCHRONOUS, .probe_type = PROBE_PREFER_ASYNCHRONOUS,