mirror of
https://github.com/torvalds/linux
synced 2024-11-05 18:23:50 +00:00
fs/ext3: use BUG_ON
if (...) BUG(); should be replaced with BUG_ON(...) when the test has no side-effects to allow a definition of BUG_ON that drops the code completely. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @ disable unlikely @ expression E,f; @@ ( if (<... f(...) ...>) { BUG(); } | - if (unlikely(E)) { BUG(); } + BUG_ON(E); ) @@ expression E,f; @@ ( if (<... f(...) ...>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
33575f8ffe
commit
269b261916
1 changed files with 1 additions and 2 deletions
|
@ -232,8 +232,7 @@ static void __rsv_window_dump(struct rb_root *root, int verbose,
|
|||
prev = rsv;
|
||||
}
|
||||
printk("Window map complete.\n");
|
||||
if (bad)
|
||||
BUG();
|
||||
BUG_ON(bad);
|
||||
}
|
||||
#define rsv_window_dump(root, verbose) \
|
||||
__rsv_window_dump((root), (verbose), __FUNCTION__)
|
||||
|
|
Loading…
Reference in a new issue