mirror of
https://github.com/torvalds/linux
synced 2024-10-04 18:33:42 +00:00
vfio/mdev: Add missing error handling to dev_set_name()
This can fail, and seems to be a popular target for syzkaller error
injection. Check the error return and unwind with put_device().
Fixes: 7b96953bc6
("vfio: Mediated device Core driver")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Message-Id: <9-v2-d36939638fc6+d54-vfio2_jgg@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
parent
fbd0e2b0c3
commit
18d731242d
|
@ -258,7 +258,9 @@ int mdev_device_create(struct mdev_type *type, const guid_t *uuid)
|
|||
list_add(&mdev->next, &mdev_list);
|
||||
mutex_unlock(&mdev_list_lock);
|
||||
|
||||
dev_set_name(&mdev->dev, "%pUl", uuid);
|
||||
ret = dev_set_name(&mdev->dev, "%pUl", uuid);
|
||||
if (ret)
|
||||
goto out_put_device;
|
||||
|
||||
/* Check if parent unregistration has started */
|
||||
if (!down_read_trylock(&parent->unreg_sem)) {
|
||||
|
|
Loading…
Reference in a new issue