mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
kexec_file: fix incorrect temp_start value in locate_mem_hole_top_down()
temp_end represents the address of the last available byte. Therefore, the starting address of the memory segment with temp_end as its last available byte and a size of `kbuf->memsz`, that is, the value of temp_start, should be `temp_end - kbuf->memsz + 1` instead of `temp_end - kbuf->memsz`. Additionally, use the ALIGN_DOWN macro instead of open-coding it directly in locate_mem_hole_top_down() to improve code readability. Link: https://lkml.kernel.org/r/20231217033528.303333-3-ytcoode@gmail.com Signed-off-by: Yuntao Wang <ytcoode@gmail.com> Acked-by: Baoquan He <bhe@redhat.com> Cc: Borislav Petkov (AMD) <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: "Eric W. Biederman" <ebiederm@xmission.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
parent
816d334afa
commit
18d565ea95
|
@ -434,11 +434,11 @@ static int locate_mem_hole_top_down(unsigned long start, unsigned long end,
|
|||
unsigned long temp_start, temp_end;
|
||||
|
||||
temp_end = min(end, kbuf->buf_max);
|
||||
temp_start = temp_end - kbuf->memsz;
|
||||
temp_start = temp_end - kbuf->memsz + 1;
|
||||
|
||||
do {
|
||||
/* align down start */
|
||||
temp_start = temp_start & (~(kbuf->buf_align - 1));
|
||||
temp_start = ALIGN_DOWN(temp_start, kbuf->buf_align);
|
||||
|
||||
if (temp_start < start || temp_start < kbuf->buf_min)
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue