mirror of
https://github.com/torvalds/linux
synced 2024-10-01 17:00:41 +00:00
KVM: ARM/arm64: avoid returning negative error code as bool
is_valid_cache returns true if the specified cache is valid. Unfortunately, if the parameter passed it out of range, we return -ENOENT, which ends up as true leading to potential hilarity. This patch returns false on the failure path instead. Cc: Christoffer Dall <christoffer.dall@linaro.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
This commit is contained in:
parent
4000be423c
commit
18d457661f
|
@ -791,7 +791,7 @@ static bool is_valid_cache(u32 val)
|
||||||
u32 level, ctype;
|
u32 level, ctype;
|
||||||
|
|
||||||
if (val >= CSSELR_MAX)
|
if (val >= CSSELR_MAX)
|
||||||
return -ENOENT;
|
return false;
|
||||||
|
|
||||||
/* Bottom bit is Instruction or Data bit. Next 3 bits are level. */
|
/* Bottom bit is Instruction or Data bit. Next 3 bits are level. */
|
||||||
level = (val >> 1);
|
level = (val >> 1);
|
||||||
|
|
|
@ -1218,7 +1218,7 @@ static bool is_valid_cache(u32 val)
|
||||||
u32 level, ctype;
|
u32 level, ctype;
|
||||||
|
|
||||||
if (val >= CSSELR_MAX)
|
if (val >= CSSELR_MAX)
|
||||||
return -ENOENT;
|
return false;
|
||||||
|
|
||||||
/* Bottom bit is Instruction or Data bit. Next 3 bits are level. */
|
/* Bottom bit is Instruction or Data bit. Next 3 bits are level. */
|
||||||
level = (val >> 1);
|
level = (val >> 1);
|
||||||
|
|
Loading…
Reference in a new issue