mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
[SCSI] scsi_dh: no need to initialize rq->cmd with blk_get_request
blk_get_request initializes rq->cmd (rq_init does) so the users don't need to do that. Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
parent
6f4267e3bd
commit
114f1ea408
|
@ -278,7 +278,6 @@ static struct request *get_req(struct scsi_device *sdev, int cmd,
|
|||
return NULL;
|
||||
}
|
||||
|
||||
memset(rq->cmd, 0, BLK_MAX_CDB);
|
||||
rq->cmd_len = COMMAND_SIZE(cmd);
|
||||
rq->cmd[0] = cmd;
|
||||
|
||||
|
|
|
@ -114,7 +114,6 @@ static int hp_sw_tur(struct scsi_device *sdev, struct hp_sw_dh_data *h)
|
|||
req->cmd_type = REQ_TYPE_BLOCK_PC;
|
||||
req->cmd_flags |= REQ_FAILFAST;
|
||||
req->cmd_len = COMMAND_SIZE(TEST_UNIT_READY);
|
||||
memset(req->cmd, 0, MAX_COMMAND_SIZE);
|
||||
req->cmd[0] = TEST_UNIT_READY;
|
||||
req->timeout = HP_SW_TIMEOUT;
|
||||
req->sense = h->sense;
|
||||
|
@ -207,7 +206,6 @@ static int hp_sw_start_stop(struct scsi_device *sdev, struct hp_sw_dh_data *h)
|
|||
req->cmd_type = REQ_TYPE_BLOCK_PC;
|
||||
req->cmd_flags |= REQ_FAILFAST;
|
||||
req->cmd_len = COMMAND_SIZE(START_STOP);
|
||||
memset(req->cmd, 0, MAX_COMMAND_SIZE);
|
||||
req->cmd[0] = START_STOP;
|
||||
req->cmd[4] = 1; /* Start spin cycle */
|
||||
req->timeout = HP_SW_TIMEOUT;
|
||||
|
|
|
@ -225,8 +225,6 @@ static struct request *get_rdac_req(struct scsi_device *sdev,
|
|||
return NULL;
|
||||
}
|
||||
|
||||
memset(rq->cmd, 0, BLK_MAX_CDB);
|
||||
|
||||
rq->cmd_type = REQ_TYPE_BLOCK_PC;
|
||||
rq->cmd_flags |= REQ_FAILFAST | REQ_NOMERGE;
|
||||
rq->retries = RDAC_RETRIES;
|
||||
|
|
Loading…
Reference in a new issue