system/linux
system/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux synced 2024-11-05 18:23:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

ACPICA: Introduce ACPI_FLEX_ARRAY

Browse source 
ACPICA commit e73b227e8e475c20cc394f237ea35d592fdf9ec3

In order to enable using -fstrict-flex-arrays with GCC and Clang in the
Linux kernel, each trailing dynamically sized array must be defined as
proper C99 "flexible array members" (FAM). Unfortunately, ACPICA has a
bunch of technical debt, dating back to before even the GNU extension of
0-length arrays, meaning the code base has many 1-element and 0-length
arrays defined at the end of structures that should actually be FAMs.

One limitation of the C99 FAM specification is the accidental requirement
that they cannot be in unions or alone in structs. There is no real-world
reason for this, though, and, actually, the existing GNU extension
permits this for 0-length arrays (which get treated as FAMs).

Add the ACPI_FLEX_ARRAY() helper macro to work around this requirement
so that FAMs can be defined in unions or alone in structs. Since this
behavior still depends on GNU extensions, keep the macro specific to GCC
(and Clang) builds. In this way, MSVC will continue to use 0-length
arrays (since it does not support the union work-around). When MSVC
grows support for this in the future, the macro can be updated.

Link: https://github.com/acpica/acpica/commit/e73b227e
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Kees Cook 2023-04-05 15:52:23 +02:00 committed by Rafael J. Wysocki
parent 2a5ab99847
commit 11132ad017
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/acpi/actypes.h
View file

@ -1323,4 +1323,8 @@ typedef enum {
#define ACPI_FALLTHROUGH do {} while(0)
#endif
#ifndef ACPI_FLEX_ARRAY
#define ACPI_FLEX_ARRAY(TYPE, NAME) TYPE NAME[0]
#endif
#endif /* __ACTYPES_H__ */

11
include/acpi/platform/acgcc.h
View file

@ -61,4 +61,15 @@
#define ACPI_FALLTHROUGH __attribute__((__fallthrough__))
#endif
/*
* Flexible array members are not allowed to be part of a union under
* C99, but this is not for any technical reason. Work around the
* limitation.
*/
#define ACPI_FLEX_ARRAY(TYPE, NAME) \
struct { \
struct { } __Empty_ ## NAME; \
TYPE NAME[]; \
}
#endif /* __ACGCC_H__ */