mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
tools/hv: Fix permissions of created directory and files
It's silly to create directories without execute permission, or to give permissions to 'other' but not the group-owner. Write the permissions in octal and 'ls -l' format since these are much easier to read than the named macros. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Tomas Hozza <thozza@redhat.com> Acked-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
40424f5fff
commit
0bffd25ce9
|
@ -235,7 +235,7 @@ static int kvp_file_init(void)
|
|||
int alloc_unit = sizeof(struct kvp_record) * ENTRIES_PER_BLOCK;
|
||||
|
||||
if (access(KVP_CONFIG_LOC, F_OK)) {
|
||||
if (mkdir(KVP_CONFIG_LOC, S_IRUSR | S_IWUSR | S_IROTH)) {
|
||||
if (mkdir(KVP_CONFIG_LOC, 0755 /* rwxr-xr-x */)) {
|
||||
syslog(LOG_ERR, " Failed to create %s", KVP_CONFIG_LOC);
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
|
@ -246,7 +246,7 @@ static int kvp_file_init(void)
|
|||
records_read = 0;
|
||||
num_blocks = 1;
|
||||
sprintf(fname, "%s/.kvp_pool_%d", KVP_CONFIG_LOC, i);
|
||||
fd = open(fname, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR | S_IROTH);
|
||||
fd = open(fname, O_RDWR | O_CREAT, 0644 /* rw-r--r-- */);
|
||||
|
||||
if (fd == -1)
|
||||
return 1;
|
||||
|
|
Loading…
Reference in a new issue