mirror of
https://github.com/torvalds/linux
synced 2024-09-06 18:01:05 +00:00
mfd: tc3589x: Remove #ifdef guards for PM related functions
Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle the .suspend/.resume callbacks. These macros allow the suspend and resume functions to be automatically dropped by the compiler when CONFIG_SUSPEND is disabled, without having to use #ifdef guards. This has the advantage of always compiling these functions in, independently of any Kconfig option. Thanks to that, bugs and other regressions are subsequently easier to catch. Signed-off-by: Paul Cercueil <paul@crapouillou.net> Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
parent
f7f292fe81
commit
02313a9009
|
@ -436,7 +436,6 @@ static void tc3589x_remove(struct i2c_client *client)
|
|||
mfd_remove_devices(tc3589x->dev);
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM_SLEEP
|
||||
static int tc3589x_suspend(struct device *dev)
|
||||
{
|
||||
struct tc3589x *tc3589x = dev_get_drvdata(dev);
|
||||
|
@ -464,9 +463,9 @@ static int tc3589x_resume(struct device *dev)
|
|||
|
||||
return ret;
|
||||
}
|
||||
#endif
|
||||
|
||||
static SIMPLE_DEV_PM_OPS(tc3589x_dev_pm_ops, tc3589x_suspend, tc3589x_resume);
|
||||
static DEFINE_SIMPLE_DEV_PM_OPS(tc3589x_dev_pm_ops,
|
||||
tc3589x_suspend, tc3589x_resume);
|
||||
|
||||
static const struct i2c_device_id tc3589x_id[] = {
|
||||
{ "tc35890", TC3589X_TC35890 },
|
||||
|
@ -483,7 +482,7 @@ MODULE_DEVICE_TABLE(i2c, tc3589x_id);
|
|||
static struct i2c_driver tc3589x_driver = {
|
||||
.driver = {
|
||||
.name = "tc3589x",
|
||||
.pm = &tc3589x_dev_pm_ops,
|
||||
.pm = pm_sleep_ptr(&tc3589x_dev_pm_ops),
|
||||
.of_match_table = of_match_ptr(tc3589x_match),
|
||||
},
|
||||
.probe_new = tc3589x_probe,
|
||||
|
|
Loading…
Reference in a new issue