nilfs2: add /sys/fs/nilfs2/features group
This patchset implements creation of sysfs groups and attributes with
the purpose to show NILFS2 volume details, internal state of the driver
and to manage internal state of NILFS2 driver.
Sysfs is a virtual file system that exports information about devices
and drivers from the kernel device model to user space, and is also used
for configuration. NILFS2 is a complex file system that has segctor
thread, GC thread, checkpoint/snapshot model and so on. Sysfs namespace
provides native and easy way for: (1) getting info and statistics about
volume state; (2) getting info and configuration of internal subsystems
(segctor thread); (3) snapshots management.
Suggested patchset provides basis for managing segctor thread behaviour
and manipulation by snapshots. Currently, it informs only about segctor
thread's internal parameters and about mounted snapshots. But sysfs
interface can provide easy and simple way for deep management of segctor
thread and snapshots.
This patchset provides opportunity to manage interval of periodical
update of superblock (in seconds). Default value is 10 seconds. Now a
user can increase this value by means of
nilfs2/<device>/superblock/sb_update_frequency attribute in the case of
necessity.
Also the patchset provides opportunity to get information easily about
key volumes's parameters (free blocks, superblock write count,
superblock update frequency, latest segment info, dirty data blocks
count, count of clean segments, count of dirty segments and so on) in
real time manner. Such information can be used in scripts for subtle
management of filesystem.
Implemented functionality creates such groups:
(1) /sys/fs/nilfs2 - root group
(2) /sys/fs/nilfs2/features - group contains attributes that describe NILFS
file system driver features
(3) /sys/fs/nilfs2/<device> - group contains attributes that describe file
system partition's details
(4) /sys/fs/nilfs2/<device>/superblock - group contains attributes that describe
superblock's details
(5) /sys/fs/nilfs2/<device>/segctor - group contains attributes that describe
segctor thread activity details
(6) /sys/fs/nilfs2/<device>/segments - group contains attributes that describe
details about volume's segments
(7) /sys/fs/nilfs2/<device>/checkpoints - group contains attributes that describe
details about volume's checkpoints
(8) /sys/fs/nilfs2/<device>/mounted_snapshots - group contains group for every
mounted snapshot
(9) /sys/fs/nilfs2/<device>/mounted_snapshots/<snapshot> - group contains
details about mounted snapshot
This patch (of 9):
This patch adds code of creation /sys/fs/nilfs2 group and
/sys/fs/nilfs2/features group.
The features group contains attributes that describe NILFS
file system driver features:
(1) revision - show current revision of NILFS file system driver.
There are two formats of timestamp output - seconds and human-readable
format. Every showed timestamp has two sysfs files (time-<xxx> and
time-<xxx>-secs). One sysfs file (time-<xxx>) shows time in
human-readable format. Another sysfs file (time-<xxx>-secs) shows time in
seconds.
It was reported by Michael Semon that timestamp output in human-readable
format should be changed from "2014-4-12 14:5:38" to "2014-04-12
14:05:38". Second version of the patch fixes this issue.
Reported-by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-08-08 21:20:37 +00:00
|
|
|
/*
|
|
|
|
* sysfs.c - sysfs support implementation.
|
|
|
|
*
|
|
|
|
* Copyright (C) 2005-2014 Nippon Telegraph and Telephone Corporation.
|
|
|
|
* Copyright (C) 2014 HGST, Inc., a Western Digital Company.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* Written by Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/kobject.h>
|
|
|
|
|
|
|
|
#include "nilfs.h"
|
|
|
|
#include "mdt.h"
|
|
|
|
#include "sufile.h"
|
|
|
|
#include "cpfile.h"
|
|
|
|
#include "sysfs.h"
|
|
|
|
|
|
|
|
/* /sys/fs/<nilfs>/ */
|
|
|
|
static struct kset *nilfs_kset;
|
|
|
|
|
|
|
|
#define NILFS_SHOW_TIME(time_t_val, buf) ({ \
|
|
|
|
struct tm res; \
|
|
|
|
int count = 0; \
|
|
|
|
time_to_tm(time_t_val, 0, &res); \
|
|
|
|
res.tm_year += 1900; \
|
|
|
|
res.tm_mon += 1; \
|
|
|
|
count = scnprintf(buf, PAGE_SIZE, \
|
|
|
|
"%ld-%.2d-%.2d %.2d:%.2d:%.2d\n", \
|
|
|
|
res.tm_year, res.tm_mon, res.tm_mday, \
|
|
|
|
res.tm_hour, res.tm_min, res.tm_sec);\
|
|
|
|
count; \
|
|
|
|
})
|
|
|
|
|
2014-08-08 21:20:42 +00:00
|
|
|
#define NILFS_DEV_INT_GROUP_OPS(name, parent_name) \
|
|
|
|
static ssize_t nilfs_##name##_attr_show(struct kobject *kobj, \
|
|
|
|
struct attribute *attr, char *buf) \
|
|
|
|
{ \
|
|
|
|
struct the_nilfs *nilfs = container_of(kobj->parent, \
|
|
|
|
struct the_nilfs, \
|
|
|
|
ns_##parent_name##_kobj); \
|
|
|
|
struct nilfs_##name##_attr *a = container_of(attr, \
|
|
|
|
struct nilfs_##name##_attr, \
|
|
|
|
attr); \
|
|
|
|
return a->show ? a->show(a, nilfs, buf) : 0; \
|
|
|
|
} \
|
|
|
|
static ssize_t nilfs_##name##_attr_store(struct kobject *kobj, \
|
|
|
|
struct attribute *attr, \
|
|
|
|
const char *buf, size_t len) \
|
|
|
|
{ \
|
|
|
|
struct the_nilfs *nilfs = container_of(kobj->parent, \
|
|
|
|
struct the_nilfs, \
|
|
|
|
ns_##parent_name##_kobj); \
|
|
|
|
struct nilfs_##name##_attr *a = container_of(attr, \
|
|
|
|
struct nilfs_##name##_attr, \
|
|
|
|
attr); \
|
|
|
|
return a->store ? a->store(a, nilfs, buf, len) : 0; \
|
|
|
|
} \
|
|
|
|
static const struct sysfs_ops nilfs_##name##_attr_ops = { \
|
|
|
|
.show = nilfs_##name##_attr_show, \
|
|
|
|
.store = nilfs_##name##_attr_store, \
|
|
|
|
};
|
|
|
|
|
|
|
|
#define NILFS_DEV_INT_GROUP_TYPE(name, parent_name) \
|
|
|
|
static void nilfs_##name##_attr_release(struct kobject *kobj) \
|
|
|
|
{ \
|
|
|
|
struct nilfs_sysfs_##parent_name##_subgroups *subgroups; \
|
|
|
|
struct the_nilfs *nilfs = container_of(kobj->parent, \
|
|
|
|
struct the_nilfs, \
|
|
|
|
ns_##parent_name##_kobj); \
|
|
|
|
subgroups = nilfs->ns_##parent_name##_subgroups; \
|
|
|
|
complete(&subgroups->sg_##name##_kobj_unregister); \
|
|
|
|
} \
|
|
|
|
static struct kobj_type nilfs_##name##_ktype = { \
|
|
|
|
.default_attrs = nilfs_##name##_attrs, \
|
|
|
|
.sysfs_ops = &nilfs_##name##_attr_ops, \
|
|
|
|
.release = nilfs_##name##_attr_release, \
|
|
|
|
};
|
|
|
|
|
|
|
|
#define NILFS_DEV_INT_GROUP_FNS(name, parent_name) \
|
|
|
|
int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
|
|
|
|
{ \
|
|
|
|
struct kobject *parent; \
|
|
|
|
struct kobject *kobj; \
|
|
|
|
struct completion *kobj_unregister; \
|
|
|
|
struct nilfs_sysfs_##parent_name##_subgroups *subgroups; \
|
|
|
|
int err; \
|
|
|
|
subgroups = nilfs->ns_##parent_name##_subgroups; \
|
|
|
|
kobj = &subgroups->sg_##name##_kobj; \
|
|
|
|
kobj_unregister = &subgroups->sg_##name##_kobj_unregister; \
|
|
|
|
parent = &nilfs->ns_##parent_name##_kobj; \
|
|
|
|
kobj->kset = nilfs_kset; \
|
|
|
|
init_completion(kobj_unregister); \
|
|
|
|
err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \
|
|
|
|
#name); \
|
|
|
|
if (err) \
|
|
|
|
return err; \
|
|
|
|
return 0; \
|
|
|
|
} \
|
|
|
|
void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
|
|
|
|
{ \
|
|
|
|
kobject_del(&nilfs->ns_##parent_name##_subgroups->sg_##name##_kobj); \
|
|
|
|
}
|
|
|
|
|
2014-08-08 21:20:44 +00:00
|
|
|
/************************************************************************
|
|
|
|
* NILFS segctor attrs *
|
|
|
|
************************************************************************/
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_pseg_block_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
sector_t last_pseg;
|
|
|
|
|
|
|
|
spin_lock(&nilfs->ns_last_segment_lock);
|
|
|
|
last_pseg = nilfs->ns_last_pseg;
|
|
|
|
spin_unlock(&nilfs->ns_last_segment_lock);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n",
|
|
|
|
(unsigned long long)last_pseg);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_seg_sequence_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
u64 last_seq;
|
|
|
|
|
|
|
|
spin_lock(&nilfs->ns_last_segment_lock);
|
|
|
|
last_seq = nilfs->ns_last_seq;
|
|
|
|
spin_unlock(&nilfs->ns_last_segment_lock);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", last_seq);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_seg_checkpoint_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
__u64 last_cno;
|
|
|
|
|
|
|
|
spin_lock(&nilfs->ns_last_segment_lock);
|
|
|
|
last_cno = nilfs->ns_last_cno;
|
|
|
|
spin_unlock(&nilfs->ns_last_segment_lock);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", last_cno);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_current_seg_sequence_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
u64 seg_seq;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
seg_seq = nilfs->ns_seg_seq;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", seg_seq);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_current_last_full_seg_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
__u64 segnum;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
segnum = nilfs->ns_segnum;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", segnum);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_next_full_seg_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
__u64 nextnum;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
nextnum = nilfs->ns_nextnum;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", nextnum);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_next_pseg_offset_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
unsigned long pseg_offset;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
pseg_offset = nilfs->ns_pseg_offset;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%lu\n", pseg_offset);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_next_checkpoint_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
__u64 cno;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
cno = nilfs->ns_cno;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", cno);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_seg_write_time_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
time_t ctime;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
ctime = nilfs->ns_ctime;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return NILFS_SHOW_TIME(ctime, buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_seg_write_time_secs_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
time_t ctime;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
ctime = nilfs->ns_ctime;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", (unsigned long long)ctime);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_nongc_write_time_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
time_t nongc_ctime;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
nongc_ctime = nilfs->ns_nongc_ctime;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return NILFS_SHOW_TIME(nongc_ctime, buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_last_nongc_write_time_secs_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
time_t nongc_ctime;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
nongc_ctime = nilfs->ns_nongc_ctime;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n",
|
|
|
|
(unsigned long long)nongc_ctime);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_dirty_data_blocks_count_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
u32 ndirtyblks;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
ndirtyblks = atomic_read(&nilfs->ns_ndirtyblks);
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%u\n", ndirtyblks);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char segctor_readme_str[] =
|
|
|
|
"The segctor group contains attributes that describe\n"
|
|
|
|
"segctor thread activity details.\n\n"
|
|
|
|
"(1) last_pseg_block\n"
|
|
|
|
"\tshow start block number of the latest segment.\n\n"
|
|
|
|
"(2) last_seg_sequence\n"
|
|
|
|
"\tshow sequence value of the latest segment.\n\n"
|
|
|
|
"(3) last_seg_checkpoint\n"
|
|
|
|
"\tshow checkpoint number of the latest segment.\n\n"
|
|
|
|
"(4) current_seg_sequence\n\tshow segment sequence counter.\n\n"
|
|
|
|
"(5) current_last_full_seg\n"
|
|
|
|
"\tshow index number of the latest full segment.\n\n"
|
|
|
|
"(6) next_full_seg\n"
|
|
|
|
"\tshow index number of the full segment index to be used next.\n\n"
|
|
|
|
"(7) next_pseg_offset\n"
|
|
|
|
"\tshow offset of next partial segment in the current full segment.\n\n"
|
|
|
|
"(8) next_checkpoint\n\tshow next checkpoint number.\n\n"
|
|
|
|
"(9) last_seg_write_time\n"
|
|
|
|
"\tshow write time of the last segment in human-readable format.\n\n"
|
|
|
|
"(10) last_seg_write_time_secs\n"
|
|
|
|
"\tshow write time of the last segment in seconds.\n\n"
|
|
|
|
"(11) last_nongc_write_time\n"
|
|
|
|
"\tshow write time of the last segment not for cleaner operation "
|
|
|
|
"in human-readable format.\n\n"
|
|
|
|
"(12) last_nongc_write_time_secs\n"
|
|
|
|
"\tshow write time of the last segment not for cleaner operation "
|
|
|
|
"in seconds.\n\n"
|
|
|
|
"(13) dirty_data_blocks_count\n"
|
|
|
|
"\tshow number of dirty data blocks.\n\n";
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_segctor_README_show(struct nilfs_segctor_attr *attr,
|
|
|
|
struct the_nilfs *nilfs, char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, segctor_readme_str);
|
|
|
|
}
|
|
|
|
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_pseg_block);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_seg_sequence);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_seg_checkpoint);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(current_seg_sequence);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(current_last_full_seg);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(next_full_seg);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(next_pseg_offset);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(next_checkpoint);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_seg_write_time);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_seg_write_time_secs);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_nongc_write_time);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(last_nongc_write_time_secs);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(dirty_data_blocks_count);
|
|
|
|
NILFS_SEGCTOR_RO_ATTR(README);
|
|
|
|
|
|
|
|
static struct attribute *nilfs_segctor_attrs[] = {
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_pseg_block),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_seg_sequence),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_seg_checkpoint),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(current_seg_sequence),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(current_last_full_seg),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(next_full_seg),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(next_pseg_offset),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(next_checkpoint),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_seg_write_time),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_seg_write_time_secs),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_nongc_write_time),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(last_nongc_write_time_secs),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(dirty_data_blocks_count),
|
|
|
|
NILFS_SEGCTOR_ATTR_LIST(README),
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
NILFS_DEV_INT_GROUP_OPS(segctor, dev);
|
|
|
|
NILFS_DEV_INT_GROUP_TYPE(segctor, dev);
|
|
|
|
NILFS_DEV_INT_GROUP_FNS(segctor, dev);
|
|
|
|
|
2014-08-08 21:20:42 +00:00
|
|
|
/************************************************************************
|
|
|
|
* NILFS superblock attrs *
|
|
|
|
************************************************************************/
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_superblock_sb_write_time_show(struct nilfs_superblock_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
time_t sbwtime;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
sbwtime = nilfs->ns_sbwtime;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return NILFS_SHOW_TIME(sbwtime, buf);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_superblock_sb_write_time_secs_show(struct nilfs_superblock_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
time_t sbwtime;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
sbwtime = nilfs->ns_sbwtime;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", (unsigned long long)sbwtime);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_superblock_sb_write_count_show(struct nilfs_superblock_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
unsigned sbwcount;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
sbwcount = nilfs->ns_sbwcount;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%u\n", sbwcount);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_superblock_sb_update_frequency_show(struct nilfs_superblock_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
unsigned sb_update_freq;
|
|
|
|
|
|
|
|
down_read(&nilfs->ns_sem);
|
|
|
|
sb_update_freq = nilfs->ns_sb_update_freq;
|
|
|
|
up_read(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%u\n", sb_update_freq);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_superblock_sb_update_frequency_store(struct nilfs_superblock_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
const char *buf, size_t count)
|
|
|
|
{
|
|
|
|
unsigned val;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
err = kstrtouint(skip_spaces(buf), 0, &val);
|
|
|
|
if (err) {
|
|
|
|
printk(KERN_ERR "NILFS: unable to convert string: err=%d\n",
|
|
|
|
err);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (val < NILFS_SB_FREQ) {
|
|
|
|
val = NILFS_SB_FREQ;
|
|
|
|
printk(KERN_WARNING "NILFS: superblock update frequency cannot be lesser than 10 seconds\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
down_write(&nilfs->ns_sem);
|
|
|
|
nilfs->ns_sb_update_freq = val;
|
|
|
|
up_write(&nilfs->ns_sem);
|
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char sb_readme_str[] =
|
|
|
|
"The superblock group contains attributes that describe\n"
|
|
|
|
"superblock's details.\n\n"
|
|
|
|
"(1) sb_write_time\n\tshow previous write time of super block "
|
|
|
|
"in human-readable format.\n\n"
|
|
|
|
"(2) sb_write_time_secs\n\tshow previous write time of super block "
|
|
|
|
"in seconds.\n\n"
|
|
|
|
"(3) sb_write_count\n\tshow write count of super block.\n\n"
|
|
|
|
"(4) sb_update_frequency\n"
|
|
|
|
"\tshow/set interval of periodical update of superblock (in seconds).\n\n"
|
|
|
|
"\tYou can set preferable frequency of superblock update by command:\n\n"
|
|
|
|
"\t'echo <val> > /sys/fs/<nilfs>/<dev>/superblock/sb_update_frequency'\n";
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
nilfs_superblock_README_show(struct nilfs_superblock_attr *attr,
|
|
|
|
struct the_nilfs *nilfs, char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, sb_readme_str);
|
|
|
|
}
|
|
|
|
|
|
|
|
NILFS_SUPERBLOCK_RO_ATTR(sb_write_time);
|
|
|
|
NILFS_SUPERBLOCK_RO_ATTR(sb_write_time_secs);
|
|
|
|
NILFS_SUPERBLOCK_RO_ATTR(sb_write_count);
|
|
|
|
NILFS_SUPERBLOCK_RW_ATTR(sb_update_frequency);
|
|
|
|
NILFS_SUPERBLOCK_RO_ATTR(README);
|
|
|
|
|
|
|
|
static struct attribute *nilfs_superblock_attrs[] = {
|
|
|
|
NILFS_SUPERBLOCK_ATTR_LIST(sb_write_time),
|
|
|
|
NILFS_SUPERBLOCK_ATTR_LIST(sb_write_time_secs),
|
|
|
|
NILFS_SUPERBLOCK_ATTR_LIST(sb_write_count),
|
|
|
|
NILFS_SUPERBLOCK_ATTR_LIST(sb_update_frequency),
|
|
|
|
NILFS_SUPERBLOCK_ATTR_LIST(README),
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
NILFS_DEV_INT_GROUP_OPS(superblock, dev);
|
|
|
|
NILFS_DEV_INT_GROUP_TYPE(superblock, dev);
|
|
|
|
NILFS_DEV_INT_GROUP_FNS(superblock, dev);
|
|
|
|
|
2014-08-08 21:20:39 +00:00
|
|
|
/************************************************************************
|
|
|
|
* NILFS device attrs *
|
|
|
|
************************************************************************/
|
|
|
|
|
|
|
|
static
|
|
|
|
ssize_t nilfs_dev_revision_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct nilfs_super_block **sbp = nilfs->ns_sbp;
|
|
|
|
u32 major = le32_to_cpu(sbp[0]->s_rev_level);
|
|
|
|
u16 minor = le16_to_cpu(sbp[0]->s_minor_rev_level);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%d.%d\n", major, minor);
|
|
|
|
}
|
|
|
|
|
|
|
|
static
|
|
|
|
ssize_t nilfs_dev_blocksize_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%u\n", nilfs->ns_blocksize);
|
|
|
|
}
|
|
|
|
|
|
|
|
static
|
|
|
|
ssize_t nilfs_dev_device_size_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct nilfs_super_block **sbp = nilfs->ns_sbp;
|
|
|
|
u64 dev_size = le64_to_cpu(sbp[0]->s_dev_size);
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n", dev_size);
|
|
|
|
}
|
|
|
|
|
|
|
|
static
|
|
|
|
ssize_t nilfs_dev_free_blocks_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
sector_t free_blocks = 0;
|
|
|
|
|
|
|
|
nilfs_count_free_blocks(nilfs, &free_blocks);
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%llu\n",
|
|
|
|
(unsigned long long)free_blocks);
|
|
|
|
}
|
|
|
|
|
|
|
|
static
|
|
|
|
ssize_t nilfs_dev_uuid_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct nilfs_super_block **sbp = nilfs->ns_sbp;
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%pUb\n", sbp[0]->s_uuid);
|
|
|
|
}
|
|
|
|
|
|
|
|
static
|
|
|
|
ssize_t nilfs_dev_volume_name_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct nilfs_super_block **sbp = nilfs->ns_sbp;
|
|
|
|
|
|
|
|
return scnprintf(buf, sizeof(sbp[0]->s_volume_name), "%s\n",
|
|
|
|
sbp[0]->s_volume_name);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char dev_readme_str[] =
|
|
|
|
"The <device> group contains attributes that describe file system\n"
|
|
|
|
"partition's details.\n\n"
|
|
|
|
"(1) revision\n\tshow NILFS file system revision.\n\n"
|
|
|
|
"(2) blocksize\n\tshow volume block size in bytes.\n\n"
|
|
|
|
"(3) device_size\n\tshow volume size in bytes.\n\n"
|
|
|
|
"(4) free_blocks\n\tshow count of free blocks on volume.\n\n"
|
|
|
|
"(5) uuid\n\tshow volume's UUID.\n\n"
|
|
|
|
"(6) volume_name\n\tshow volume's name.\n\n";
|
|
|
|
|
|
|
|
static ssize_t nilfs_dev_README_show(struct nilfs_dev_attr *attr,
|
|
|
|
struct the_nilfs *nilfs,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, dev_readme_str);
|
|
|
|
}
|
|
|
|
|
|
|
|
NILFS_DEV_RO_ATTR(revision);
|
|
|
|
NILFS_DEV_RO_ATTR(blocksize);
|
|
|
|
NILFS_DEV_RO_ATTR(device_size);
|
|
|
|
NILFS_DEV_RO_ATTR(free_blocks);
|
|
|
|
NILFS_DEV_RO_ATTR(uuid);
|
|
|
|
NILFS_DEV_RO_ATTR(volume_name);
|
|
|
|
NILFS_DEV_RO_ATTR(README);
|
|
|
|
|
|
|
|
static struct attribute *nilfs_dev_attrs[] = {
|
|
|
|
NILFS_DEV_ATTR_LIST(revision),
|
|
|
|
NILFS_DEV_ATTR_LIST(blocksize),
|
|
|
|
NILFS_DEV_ATTR_LIST(device_size),
|
|
|
|
NILFS_DEV_ATTR_LIST(free_blocks),
|
|
|
|
NILFS_DEV_ATTR_LIST(uuid),
|
|
|
|
NILFS_DEV_ATTR_LIST(volume_name),
|
|
|
|
NILFS_DEV_ATTR_LIST(README),
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
static ssize_t nilfs_dev_attr_show(struct kobject *kobj,
|
|
|
|
struct attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
struct the_nilfs *nilfs = container_of(kobj, struct the_nilfs,
|
|
|
|
ns_dev_kobj);
|
|
|
|
struct nilfs_dev_attr *a = container_of(attr, struct nilfs_dev_attr,
|
|
|
|
attr);
|
|
|
|
|
|
|
|
return a->show ? a->show(a, nilfs, buf) : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t nilfs_dev_attr_store(struct kobject *kobj,
|
|
|
|
struct attribute *attr,
|
|
|
|
const char *buf, size_t len)
|
|
|
|
{
|
|
|
|
struct the_nilfs *nilfs = container_of(kobj, struct the_nilfs,
|
|
|
|
ns_dev_kobj);
|
|
|
|
struct nilfs_dev_attr *a = container_of(attr, struct nilfs_dev_attr,
|
|
|
|
attr);
|
|
|
|
|
|
|
|
return a->store ? a->store(a, nilfs, buf, len) : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nilfs_dev_attr_release(struct kobject *kobj)
|
|
|
|
{
|
|
|
|
struct the_nilfs *nilfs = container_of(kobj, struct the_nilfs,
|
|
|
|
ns_dev_kobj);
|
|
|
|
complete(&nilfs->ns_dev_kobj_unregister);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct sysfs_ops nilfs_dev_attr_ops = {
|
|
|
|
.show = nilfs_dev_attr_show,
|
|
|
|
.store = nilfs_dev_attr_store,
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct kobj_type nilfs_dev_ktype = {
|
|
|
|
.default_attrs = nilfs_dev_attrs,
|
|
|
|
.sysfs_ops = &nilfs_dev_attr_ops,
|
|
|
|
.release = nilfs_dev_attr_release,
|
|
|
|
};
|
|
|
|
|
|
|
|
int nilfs_sysfs_create_device_group(struct super_block *sb)
|
|
|
|
{
|
|
|
|
struct the_nilfs *nilfs = sb->s_fs_info;
|
2014-08-08 21:20:42 +00:00
|
|
|
size_t devgrp_size = sizeof(struct nilfs_sysfs_dev_subgroups);
|
2014-08-08 21:20:39 +00:00
|
|
|
int err;
|
|
|
|
|
2014-08-08 21:20:42 +00:00
|
|
|
nilfs->ns_dev_subgroups = kzalloc(devgrp_size, GFP_KERNEL);
|
|
|
|
if (unlikely(!nilfs->ns_dev_subgroups)) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
printk(KERN_ERR "NILFS: unable to allocate memory for device group\n");
|
|
|
|
goto failed_create_device_group;
|
|
|
|
}
|
|
|
|
|
2014-08-08 21:20:39 +00:00
|
|
|
nilfs->ns_dev_kobj.kset = nilfs_kset;
|
|
|
|
init_completion(&nilfs->ns_dev_kobj_unregister);
|
|
|
|
err = kobject_init_and_add(&nilfs->ns_dev_kobj, &nilfs_dev_ktype, NULL,
|
|
|
|
"%s", sb->s_id);
|
|
|
|
if (err)
|
2014-08-08 21:20:42 +00:00
|
|
|
goto free_dev_subgroups;
|
|
|
|
|
|
|
|
err = nilfs_sysfs_create_superblock_group(nilfs);
|
|
|
|
if (err)
|
|
|
|
goto cleanup_dev_kobject;
|
2014-08-08 21:20:39 +00:00
|
|
|
|
2014-08-08 21:20:44 +00:00
|
|
|
err = nilfs_sysfs_create_segctor_group(nilfs);
|
|
|
|
if (err)
|
|
|
|
goto delete_superblock_group;
|
|
|
|
|
2014-08-08 21:20:39 +00:00
|
|
|
return 0;
|
|
|
|
|
2014-08-08 21:20:44 +00:00
|
|
|
delete_superblock_group:
|
|
|
|
nilfs_sysfs_delete_superblock_group(nilfs);
|
|
|
|
|
2014-08-08 21:20:42 +00:00
|
|
|
cleanup_dev_kobject:
|
|
|
|
kobject_del(&nilfs->ns_dev_kobj);
|
|
|
|
|
|
|
|
free_dev_subgroups:
|
|
|
|
kfree(nilfs->ns_dev_subgroups);
|
|
|
|
|
2014-08-08 21:20:39 +00:00
|
|
|
failed_create_device_group:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
void nilfs_sysfs_delete_device_group(struct the_nilfs *nilfs)
|
|
|
|
{
|
2014-08-08 21:20:42 +00:00
|
|
|
nilfs_sysfs_delete_superblock_group(nilfs);
|
2014-08-08 21:20:44 +00:00
|
|
|
nilfs_sysfs_delete_segctor_group(nilfs);
|
2014-08-08 21:20:39 +00:00
|
|
|
kobject_del(&nilfs->ns_dev_kobj);
|
2014-08-08 21:20:42 +00:00
|
|
|
kfree(nilfs->ns_dev_subgroups);
|
2014-08-08 21:20:39 +00:00
|
|
|
}
|
|
|
|
|
nilfs2: add /sys/fs/nilfs2/features group
This patchset implements creation of sysfs groups and attributes with
the purpose to show NILFS2 volume details, internal state of the driver
and to manage internal state of NILFS2 driver.
Sysfs is a virtual file system that exports information about devices
and drivers from the kernel device model to user space, and is also used
for configuration. NILFS2 is a complex file system that has segctor
thread, GC thread, checkpoint/snapshot model and so on. Sysfs namespace
provides native and easy way for: (1) getting info and statistics about
volume state; (2) getting info and configuration of internal subsystems
(segctor thread); (3) snapshots management.
Suggested patchset provides basis for managing segctor thread behaviour
and manipulation by snapshots. Currently, it informs only about segctor
thread's internal parameters and about mounted snapshots. But sysfs
interface can provide easy and simple way for deep management of segctor
thread and snapshots.
This patchset provides opportunity to manage interval of periodical
update of superblock (in seconds). Default value is 10 seconds. Now a
user can increase this value by means of
nilfs2/<device>/superblock/sb_update_frequency attribute in the case of
necessity.
Also the patchset provides opportunity to get information easily about
key volumes's parameters (free blocks, superblock write count,
superblock update frequency, latest segment info, dirty data blocks
count, count of clean segments, count of dirty segments and so on) in
real time manner. Such information can be used in scripts for subtle
management of filesystem.
Implemented functionality creates such groups:
(1) /sys/fs/nilfs2 - root group
(2) /sys/fs/nilfs2/features - group contains attributes that describe NILFS
file system driver features
(3) /sys/fs/nilfs2/<device> - group contains attributes that describe file
system partition's details
(4) /sys/fs/nilfs2/<device>/superblock - group contains attributes that describe
superblock's details
(5) /sys/fs/nilfs2/<device>/segctor - group contains attributes that describe
segctor thread activity details
(6) /sys/fs/nilfs2/<device>/segments - group contains attributes that describe
details about volume's segments
(7) /sys/fs/nilfs2/<device>/checkpoints - group contains attributes that describe
details about volume's checkpoints
(8) /sys/fs/nilfs2/<device>/mounted_snapshots - group contains group for every
mounted snapshot
(9) /sys/fs/nilfs2/<device>/mounted_snapshots/<snapshot> - group contains
details about mounted snapshot
This patch (of 9):
This patch adds code of creation /sys/fs/nilfs2 group and
/sys/fs/nilfs2/features group.
The features group contains attributes that describe NILFS
file system driver features:
(1) revision - show current revision of NILFS file system driver.
There are two formats of timestamp output - seconds and human-readable
format. Every showed timestamp has two sysfs files (time-<xxx> and
time-<xxx>-secs). One sysfs file (time-<xxx>) shows time in
human-readable format. Another sysfs file (time-<xxx>-secs) shows time in
seconds.
It was reported by Michael Semon that timestamp output in human-readable
format should be changed from "2014-4-12 14:5:38" to "2014-04-12
14:05:38". Second version of the patch fixes this issue.
Reported-by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Vyacheslav Dubeyko <Vyacheslav.Dubeyko@hgst.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-08-08 21:20:37 +00:00
|
|
|
/************************************************************************
|
|
|
|
* NILFS feature attrs *
|
|
|
|
************************************************************************/
|
|
|
|
|
|
|
|
static ssize_t nilfs_feature_revision_show(struct kobject *kobj,
|
|
|
|
struct attribute *attr, char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%d.%d\n",
|
|
|
|
NILFS_CURRENT_REV, NILFS_MINOR_REV);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const char features_readme_str[] =
|
|
|
|
"The features group contains attributes that describe NILFS file\n"
|
|
|
|
"system driver features.\n\n"
|
|
|
|
"(1) revision\n\tshow current revision of NILFS file system driver.\n";
|
|
|
|
|
|
|
|
static ssize_t nilfs_feature_README_show(struct kobject *kobj,
|
|
|
|
struct attribute *attr,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
return snprintf(buf, PAGE_SIZE, features_readme_str);
|
|
|
|
}
|
|
|
|
|
|
|
|
NILFS_FEATURE_RO_ATTR(revision);
|
|
|
|
NILFS_FEATURE_RO_ATTR(README);
|
|
|
|
|
|
|
|
static struct attribute *nilfs_feature_attrs[] = {
|
|
|
|
NILFS_FEATURE_ATTR_LIST(revision),
|
|
|
|
NILFS_FEATURE_ATTR_LIST(README),
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group nilfs_feature_attr_group = {
|
|
|
|
.name = "features",
|
|
|
|
.attrs = nilfs_feature_attrs,
|
|
|
|
};
|
|
|
|
|
|
|
|
int __init nilfs_sysfs_init(void)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
|
|
|
|
nilfs_kset = kset_create_and_add(NILFS_ROOT_GROUP_NAME, NULL, fs_kobj);
|
|
|
|
if (!nilfs_kset) {
|
|
|
|
err = -ENOMEM;
|
|
|
|
printk(KERN_ERR "NILFS: unable to create sysfs entry: err %d\n",
|
|
|
|
err);
|
|
|
|
goto failed_sysfs_init;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = sysfs_create_group(&nilfs_kset->kobj, &nilfs_feature_attr_group);
|
|
|
|
if (unlikely(err)) {
|
|
|
|
printk(KERN_ERR "NILFS: unable to create feature group: err %d\n",
|
|
|
|
err);
|
|
|
|
goto cleanup_sysfs_init;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
cleanup_sysfs_init:
|
|
|
|
kset_unregister(nilfs_kset);
|
|
|
|
|
|
|
|
failed_sysfs_init:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
void nilfs_sysfs_exit(void)
|
|
|
|
{
|
|
|
|
sysfs_remove_group(&nilfs_kset->kobj, &nilfs_feature_attr_group);
|
|
|
|
kset_unregister(nilfs_kset);
|
|
|
|
}
|