Go to file
John Baldwin fd99905b45 libiscsiutil: Fix a memory leak with negotiation keys.
When keys are loaded from a received PDU, a copy of the received keys
block is saved in the keys struct and the name and value pointers
point into that saved block.  Freeing the keys frees this block.

However, when keys are added to a keys struct to build a set of keys
later sent in a PDU, the keys data block pointer is not used and
individual key names and values hold allocated strings.  When the keys
structure was freed, all of these individual key name and value
strings were leaked.

Instead, allocate copies of strings for names and values when parsing
a set of keys from a received PDU and free all of the individual key
name and value strings when deleting a set of keys.

Reviewed by:	mav
Sponsored by:	Chelsio Communications
Differential Revision:	https://reviews.freebsd.org/D33545
2021-12-22 10:43:23 -08:00
.cirrus-ci Cirrus-CI: add some timing info on pkg install failure 2021-08-04 15:02:00 -04:00
.github [skip ci] fix syntax in CODEOWNERS 2021-07-22 10:58:54 -06:00
bin pkgbase: Create a FreeBSD-csh package 2021-12-21 10:17:50 +01:00
cddl dtrace: Disable getf() as it is broken on FreeBSD 2021-12-17 13:10:22 -05:00
contrib tzcode: fix tz change detection logic 2021-12-21 12:01:24 -06:00
crypto ssh: disable RSA/SHA-1 signatures 2021-12-19 11:03:45 -05:00
etc pkgbase: Create a FreeBSD-mtree package 2021-12-21 10:17:33 +01:00
gnu libdialog: Bump shared library version to 10. 2021-10-27 09:30:24 -07:00
include ipfilter: Move kernel bits to netpfil 2021-12-20 06:16:33 -08:00
kerberos5 pkgbase: Create a FreeBSD-kerberos package 2021-09-07 10:23:14 +02:00
lib libiscsiutil: Fix a memory leak with negotiation keys. 2021-12-22 10:43:23 -08:00
libexec pkgbase: Create a FreeBSD-ftpd package 2021-12-21 10:17:36 +01:00
release pkgbase: Create a FreeBSD-csh package 2021-12-21 10:17:50 +01:00
rescue Add an internal libiscsiutil library. 2021-12-22 10:43:11 -08:00
sbin pkgbase: Put more binaries/lib in runtime 2021-12-21 10:17:27 +01:00
secure OpenSSL: Merge OpenSSL 1.1.1m 2021-12-14 16:03:52 -05:00
share Add an internal libiscsiutil library. 2021-12-22 10:43:11 -08:00
stand loader.efi: to preserve heap space, use AllocatePages() for shadow_fb 2021-12-22 11:39:28 +02:00
sys Fix buffer overread in preloaded hostuuid parsing 2021-12-22 16:47:23 +00:00
targets Retire obsolete iscsi_initiator(4) 2021-10-26 16:17:35 -04:00
tests tests/libalias: Make inline functions static inline 2021-12-20 10:52:25 +01:00
tools nanobsd: sync base system ssh config files 2021-12-20 11:11:00 -05:00
usr.bin bsddialog: import version 0.0.2 2021-12-21 16:13:00 +01:00
usr.sbin Add an internal libiscsiutil library. 2021-12-22 10:43:11 -08:00
.arcconfig Remove history.immutable from .arcconfig 2021-04-13 12:36:25 +01:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.cirrus.yml Cirrus-CI: build with LLVM 13 package 2021-11-18 09:57:33 -05:00
.clang-format clang-format: Add bitset loop macros 2021-09-21 12:08:01 -04:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore bsddialog: import snapshot 0.0.2 2021-12-21 16:06:19 +01:00
COPYRIGHT copyrights: Happy New Year 2021 2020-12-31 10:29:44 -05:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Remove myself from bhyve maintenance; ENOTIME. 2021-11-19 07:09:30 +10:00
Makefile Test various header files to ensure they can be included by themselves. 2021-12-14 20:25:37 -07:00
Makefile.inc1 test-includes: Build a library instead of a binary 2021-12-15 15:35:24 -07:00
Makefile.libcompat libcompat: Remove MIPS from list of compat libraries 2021-12-09 08:22:51 -07:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc libefivar(3): efi_set_variables_supported.3 should be efi_variables_supported.3 2021-12-21 20:42:39 +08:00
README.md README.md: update gnu directory description 2021-12-17 08:45:31 -05:00
RELNOTES RELNOTES: Note support for KTLS RX for TLS 1.3. 2021-12-14 11:02:45 -08:00
UPDATING Test various header files to ensure they can be included by themselves. 2021-12-14 20:25:37 -07:00

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Commands and libraries under the GNU General Public License (GPL) or Lesser General Public License (LGPL). Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources.
sys/arch/conf Kernel configuration files. GENERIC is the configuration used in release builds. NOTES contains documentation of all possible entries.
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.