mirror of
https://github.com/freebsd/freebsd-src
synced 2024-07-22 18:56:38 +00:00
30189156d3
This would previously return 1 if the slave side of the pts was closed to force an application to read() from it and observe the EOF, but it's not clear why and this is inconsistent both with how we handle devices with similar mechanics (like pipes) and also with other kernels, such as OpenBSD/NetBSD and Linux. PR: 239604 Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D43457
65 lines
1.6 KiB
C
65 lines
1.6 KiB
C
/*-
|
|
* Copyright (c) 2024 Kyle Evans <kevans@FreeBSD.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/ioctl.h>
|
|
|
|
#include <termios.h>
|
|
|
|
#include <atf-c.h>
|
|
#include <libutil.h>
|
|
|
|
/* Just a little more concise. */
|
|
#define newpty(masterp, slavep) openpty((masterp), (slavep), NULL, NULL, NULL)
|
|
|
|
ATF_TC_WITHOUT_HEAD(fionread);
|
|
ATF_TC_BODY(fionread, tc)
|
|
{
|
|
char rbuf[32];
|
|
char buf[] = "Hello";
|
|
int master, slave;
|
|
int bytes;
|
|
|
|
ATF_REQUIRE_EQ(0, newpty(&master, &slave));
|
|
|
|
/* Should be empty to begin with. */
|
|
ATF_REQUIRE_EQ(0, ioctl(master, FIONREAD, &bytes));
|
|
ATF_REQUIRE_EQ(0, bytes);
|
|
|
|
ATF_REQUIRE_EQ(sizeof(buf) - 1, write(slave, buf, sizeof(buf) - 1));
|
|
ATF_REQUIRE_EQ(0, ioctl(master, FIONREAD, &bytes));
|
|
ATF_REQUIRE_EQ(sizeof(buf) - 1, bytes);
|
|
|
|
/* Drain what we have available, should result in 0 bytes again. */
|
|
ATF_REQUIRE_EQ(sizeof(buf) - 1, read(master, rbuf, sizeof(rbuf)));
|
|
ATF_REQUIRE_EQ(0, ioctl(master, FIONREAD, &bytes));
|
|
ATF_REQUIRE_EQ(0, bytes);
|
|
|
|
/*
|
|
* Write once more, then close the slave side with data still in the
|
|
* buffer.
|
|
*/
|
|
ATF_REQUIRE_EQ(sizeof(buf) - 1, write(slave, buf, sizeof(buf) - 1));
|
|
ATF_REQUIRE_EQ(0, ioctl(master, FIONREAD, &bytes));
|
|
ATF_REQUIRE_EQ(sizeof(buf) - 1, bytes);
|
|
|
|
ATF_REQUIRE_EQ(0, close(slave));
|
|
|
|
/*
|
|
* The tty's output queue is discarded upon close, so we shouldn't have
|
|
* anything else to read().
|
|
*/
|
|
ATF_REQUIRE_EQ(0, ioctl(master, FIONREAD, &bytes));
|
|
ATF_REQUIRE_EQ(0, bytes);
|
|
ATF_REQUIRE_EQ(0, read(master, rbuf, sizeof(rbuf)));
|
|
}
|
|
|
|
ATF_TP_ADD_TCS(tp)
|
|
{
|
|
ATF_TP_ADD_TC(tp, fionread);
|
|
return (atf_no_error());
|
|
}
|