mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-02 06:35:36 +00:00
aadb4a1b3f
Similarly as in the previous commit, using calloc() instead of malloc() is useless here in the regular case since the subsequent call to cpuset_getaffinify() is going to completely fill the allocated memory. However, there is an additional complication. This function tries to allocate memory to hold the cpuset if it previously wasn't, and does so before the thread lock is acquired, which can fail on a bad thread ID. In this case, it is necessary to deallocate the memory allocated in this function so that the attributes object appears unmodified to the caller when an error is returned. Without this, a subsequent call to pthread_attr_getaffinity_np() would expose uninitialized memory (not a security problem per se, since it comes from the same process) instead of returning a full mask as it would before the failing call to pthread_attr_get_np(). So the caller would be able to notice a change in the state of the attributes object even if pthread_attr_get_np() reported failure, which would be quite surprising. A similar problem that could occur on failure of cpuset_setaffinity() has been fixed. Finally, we shall always report memory allocation failure. This already goes for pthread_attr_init(), so, if for nothing else, just be consistent. Reviewed by: emaste, kib Approved by: emaste (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43329 |
||
|---|---|---|
| .. | ||
| atf | ||
| clang | ||
| csu | ||
| flua | ||
| geom | ||
| googletest | ||
| lib9p | ||
| lib80211 | ||
| libalias | ||
| libarchive | ||
| libauditd | ||
| libbe | ||
| libbearssl | ||
| libbegemot | ||
| libblacklist | ||
| libblocksruntime | ||
| libbluetooth | ||
| libbsddialog | ||
| libbsdstat | ||
| libbsm | ||
| libbsnmp | ||
| libbz2 | ||
| libc | ||
| libc++ | ||
| libc++experimental | ||
| libc_nonshared | ||
| libcalendar | ||
| libcam | ||
| libcapsicum | ||
| libcasper | ||
| libcbor | ||
| libclang_rt | ||
| libcom_err | ||
| libcompat | ||
| libcompiler_rt | ||
| libcrypt | ||
| libcuse | ||
| libcxxrt | ||
| libdevctl | ||
| libdevdctl | ||
| libdevinfo | ||
| libdevstat | ||
| libdl | ||
| libdpv | ||
| libdwarf | ||
| libedit | ||
| libefivar | ||
| libelf | ||
| libelftc | ||
| libevent1 | ||
| libexecinfo | ||
| libexpat | ||
| libfetch | ||
| libfido2 | ||
| libfigpar | ||
| libgcc_eh | ||
| libgcc_s | ||
| libgeom | ||
| libgpio | ||
| libgssapi | ||
| libiconv_modules | ||
| libifconfig | ||
| libipsec | ||
| libipt | ||
| libiscsiutil | ||
| libjail | ||
| libkiconv | ||
| libkvm | ||
| libldns | ||
| liblua | ||
| liblutok | ||
| liblzma | ||
| libmagic | ||
| libmd | ||
| libmemstat | ||
| libmilter | ||
| libmixer | ||
| libmp | ||
| libmt | ||
| libnetbsd | ||
| libnetgraph | ||
| libnetmap | ||
| libnv | ||
| libomp | ||
| libopenbsd | ||
| libopencsd | ||
| libpam | ||
| libpathconv | ||
| libpcap | ||
| libpe | ||
| libpfctl | ||
| libpjdlog | ||
| libpmc | ||
| libpmcstat | ||
| libproc | ||
| libprocstat | ||
| libradius | ||
| libregex | ||
| librpcsec_gss | ||
| librpcsvc | ||
| librss | ||
| librt | ||
| librtld_db | ||
| libsbuf | ||
| libsdp | ||
| libsecureboot | ||
| libsm | ||
| libsmb | ||
| libsmdb | ||
| libsmutil | ||
| libsqlite3 | ||
| libssp | ||
| libssp_nonshared | ||
| libstats | ||
| libstdbuf | ||
| libstdthreads | ||
| libsysdecode | ||
| libtacplus | ||
| libtelnet | ||
| libthr | ||
| libthread_db | ||
| libucl | ||
| libufs | ||
| libugidfw | ||
| libulog | ||
| libunbound | ||
| libusb | ||
| libusbhid | ||
| libutil | ||
| libveriexec | ||
| libvgl | ||
| libvmmapi | ||
| libwrap | ||
| libxo | ||
| liby | ||
| libypclnt | ||
| libz | ||
| libzstd | ||
| msun | ||
| ncurses | ||
| nss_tacplus | ||
| ofed | ||
| tests | ||
| Makefile | ||
| Makefile.inc | ||