John Baldwin 95b66e9e53 Close a race between sleepq_broadcast() and sleepq_catch_signals(). ... Specifically, sleepq_broadcast() uses td_slpq for its private pending queue of threads that it is going to wake up after it takes them off the sleep queue. The problem is that if one of the threads is actually not asleep yet, then we can end up with td_slpq being corrupted and/or the thread being made runnable at the wrong time resulting in the td_sleepqueue == NULL assertion failures occasionally reported under heavy load. The fix is to stop being so fancy and ditch the whole pending queue bit. Instead, sleepq_remove_thread() and sleepq_resume_thread() were merged into one function that requires the caller to hold sched_lock. This fixes several places that unlocked sched_lock only to call a function that then locked sched_lock, so even though sched_lock is now held slightly longer, removing the extra lock acquires (1 pair instead of 3 in some cases) probably makes it an overall win if you don't include the fact that it closes a race. This is definitely a 5.4 candidate. PR: kern/79693 Submitted by: Steven Sears stevenjsears at yahoo dot com MFC after: 4 days		2005-04-14 06:30:32 +00:00
..
bus_if.m	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
clock_if.m	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
cpufreq_if.m	Introduce a new method, cpufreq_drv_type(), that returns the type of the	2005-02-18 00:23:36 +00:00
device_if.m	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
genassym.sh
imgact_aout.c	o Split out kernel part of execve(2) syscall into two parts: one that	2005-01-29 23:12:00 +00:00
imgact_elf.c	Remove GIANT_REQUIRED from elfN_load_section().	2005-04-03 07:57:47 +00:00
imgact_elf32.c	Use __FBSDID().	2003-06-11 00:56:59 +00:00
imgact_elf64.c	Use __FBSDID().	2003-06-11 00:56:59 +00:00
imgact_gzip.c	- Change the vm_mmap() function to accept an objtype_t parameter specifying	2005-04-01 20:00:11 +00:00
imgact_shell.c	o Replace two while {} do loops with more appropriate do {} while loops. This	2005-02-25 10:17:53 +00:00
inflate.c	Use __FBSDID().	2003-06-11 00:56:59 +00:00
init_main.c	Add /rescue/init to the default init_path, before /stand/sysinstall.	2005-02-17 10:00:10 +00:00
init_sysent.c	regen	2005-03-01 17:44:34 +00:00
kern_acct.c	When mac_check_system_acct() fails, make sure to unlock as well as close	2005-03-01 08:56:13 +00:00
kern_acl.c	Rename suser_cred()'s PRISON_ROOT flag to SUSER_ALLOWJAIL. This is	2004-07-26 07:24:04 +00:00
kern_alq.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_clock.c	- Define KTR points for KTR_SCHED.	2004-12-26 00:14:21 +00:00
kern_condvar.c	Refine the turnstile and sleep queue interfaces just a bit:	2004-10-12 18:36:20 +00:00
kern_conf.c	cdev (still) needs per instance uid/gid/mode	2005-03-31 10:29:57 +00:00
kern_context.c	Change the clear_ret argument of get_mcontext() to be a flags argument.	2003-11-09 20:31:04 +00:00
kern_cpu.c	Add debugging prints to all the methods in case there are problems with	2005-04-10 19:11:23 +00:00
kern_descrip.c	Remove redundant initialization that is repeated in the for() loop	2005-03-08 16:57:20 +00:00
kern_environment.c	My addled brains didn't realize that since vtp points into value, we	2005-03-09 12:16:45 +00:00
kern_event.c	fix aio+kq... I've been running ambrisko's test program for much longer	2005-03-18 01:11:39 +00:00
kern_exec.c	Welcome to the 21st century: increase MAXSHELLCMDLEN from 128 bytes to	2005-02-25 11:49:42 +00:00
kern_exit.c	- A lock is required before calling VOP_REVOKE. Our reference protects us	2005-03-13 11:47:04 +00:00
kern_fork.c	Divorce critical sections from spinlocks. Critical sections as denoted by	2005-04-04 21:53:56 +00:00
kern_idle.c	Divorce critical sections from spinlocks. Critical sections as denoted by	2005-04-04 21:53:56 +00:00
kern_intr.c	Use PCPU_LAZY_INC() for cnt.v_{intr,trap,syscalls} rather than atomic	2005-04-12 23:18:54 +00:00
kern_jail.c	- Use taskqueue_thread rather than taskqueue_swi since our task is going	2005-04-05 08:51:45 +00:00
kern_kse.c	Drop bzero and shove the responsibility of zeroing the kse upcall	2005-02-24 00:05:50 +00:00
kern_kthread.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_ktr.c	- Change the ddb paging "support" to use a variable (db_lines_per_page) to	2004-11-01 22:15:15 +00:00
kern_ktrace.c	Make a SYSCTL_NODE static	2005-02-10 12:23:29 +00:00
kern_linker.c	- Denote a few places where kobj class references are manipulated without	2005-03-31 22:49:31 +00:00
kern_lock.c	- Differentiate two UPGRADE panics so I have a better idea of what's going	2005-04-12 05:43:03 +00:00
kern_lockf.c	Print name of device instead of useless major/minor numbers.	2005-03-29 08:13:01 +00:00
kern_mac.c	Bump MAC Framework version to 2 in preparation for the upcoming API/ABI	2004-11-09 11:28:40 +00:00
kern_malloc.c	Consistently style function declarations in kern_malloc.c.	2005-04-12 23:54:34 +00:00
kern_mbuf.c	Well, it seems that I pre-maturely removed the "All rights reserved"	2005-02-16 21:45:59 +00:00
kern_mib.c	Add a sysctl that records the amount of physical memory in the machine.	2005-02-28 21:42:56 +00:00
kern_module.c	Swap the arguments for CP so we copy the correct source and	2005-02-18 22:14:40 +00:00
kern_mtxpool.c	Make a bunch of malloc types static.	2005-02-10 12:02:37 +00:00
kern_mutex.c	Add additional newline to debug.mutex.prof.stats header, so that	2005-04-08 14:14:09 +00:00
kern_ntptime.c	Implement kern_adjtime(), kern_readv(), kern_sched_rr_get_interval(),	2005-03-31 22:51:18 +00:00
kern_physio.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_poll.c	Remove recently added note about DEVICE_POLLING not working with SMP.	2005-02-25 22:07:51 +00:00
kern_proc.c	Divorce critical sections from spinlocks. Critical sections as denoted by	2005-04-04 21:53:56 +00:00
kern_prot.c	Impose the upper limit on signals that are allowed between kernel threads	2005-03-18 13:33:18 +00:00
kern_resource.c	Stop explicitly touching td_base_pri outside of the scheduler and simply	2004-12-30 20:29:58 +00:00
kern_sema.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_shutdown.c	- Remove unused include.	2005-04-12 05:45:58 +00:00
kern_sig.c	Suspend all other threads in the process while generating a core dump.	2005-04-10 02:31:24 +00:00
kern_subr.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_switch.c	Sprinkle some volatile magic and rearrange things a bit to avoid race	2005-04-08 03:37:53 +00:00
kern_sx.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_synch.c	Sprinkle some volatile magic and rearrange things a bit to avoid race	2005-04-08 03:37:53 +00:00
kern_syscalls.c	Do a pass over all modules in the kernel and make them return EOPNOTSUPP	2004-07-15 08:26:07 +00:00
kern_sysctl.c	Make another bunch of SYSCTL_NODEs static	2005-02-10 12:16:08 +00:00
kern_tc.c	s/ENOTTY/ENOIOCTL/	2005-03-26 20:04:28 +00:00
kern_thr.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_thread.c	Fix code freeing wrong cred pointer.	2005-03-21 22:55:38 +00:00
kern_time.c	Implement kern_adjtime(), kern_readv(), kern_sched_rr_get_interval(),	2005-03-31 22:51:18 +00:00
kern_timeout.c	When processing a timeout() callout and returning it to the free	2005-02-11 00:14:00 +00:00
kern_umtx.c	Allocate umtx_q from heap instead of stack, this avoids	2005-03-05 09:15:03 +00:00
kern_uuid.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
kern_xxx.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
ksched.c	/* -> /*- for license, minor formatting changes	2005-01-07 02:29:27 +00:00
link_elf.c	Normalize the VM wiring done with SPARSE_MAPPING: check for errors, and	2004-08-09 18:46:13 +00:00
link_elf_obj.c	Add support for completing the installation of ELF relocatable	2004-08-29 01:21:51 +00:00
linker_if.m	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
Make.tags.inc
Makefile
makesyscalls.sh	Remove the namespace column from the syscalls tables. We don't actually	2003-12-23 03:50:43 +00:00
md4c.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
md5c.c	MD5Pad() should never have been exposed.	2005-02-10 12:20:42 +00:00
p1003_1b.c	Actually commit the code for kern_sched_get_rr_interval().	2005-03-31 22:54:48 +00:00
posix4_mib.c	Back when VOP_* was introduced, we did not have new-style struct	2004-12-01 23:16:38 +00:00
sched_4bsd.c	Sprinkle some volatile magic and rearrange things a bit to avoid race	2005-04-08 03:37:53 +00:00
sched_ule.c	Sprinkle some volatile magic and rearrange things a bit to avoid race	2005-04-08 03:37:53 +00:00
subr_acl_posix1e.c	Rename suser_cred()'s PRISON_ROOT flag to SUSER_ALLOWJAIL. This is	2004-07-26 07:24:04 +00:00
subr_autoconf.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_blist.c	Move the definitions of SWAPBLK_NONE and SWAPBLK_MASK from vm_page.h to	2004-06-04 04:03:26 +00:00
subr_bus.c	resource_list_purge: release the resources in this list, and purge the	2005-04-12 15:20:36 +00:00
subr_clist.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_clock.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_devstat.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_disk.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_eventhandler.c	eliminate potential null deref	2005-02-23 19:32:29 +00:00
subr_hints.c	Don't set ret_namelen and ret_resnamelen in res_find() unless both the	2005-03-24 21:20:25 +00:00
subr_kdb.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_kobj.c	* Add multiple inheritance to kobj. Each class can have zero or more base	2003-10-16 09:16:28 +00:00
subr_log.c	Use dynamic major number allocation.	2005-02-27 22:02:03 +00:00
subr_mbpool.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_mchain.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_module.c	Use __FBSDID().	2003-06-11 00:56:59 +00:00
subr_msgbuf.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_param.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_pcpu.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_power.c	Move the kernel power change printf under bootverbose since the	2004-01-02 18:24:13 +00:00
subr_prf.c	Constify hexdump() harder.	2005-04-06 10:14:13 +00:00
subr_prof.c	netchild's mega-patch to isolate compiler dependencies into a central	2005-03-02 21:33:29 +00:00
subr_rman.c	rman_set_device() seems to have been omitted by mistake. Implement it.	2005-04-12 06:21:59 +00:00
subr_rtc.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_sbuf.c	Make a bunch of malloc types static.	2005-02-10 12:02:37 +00:00
subr_scanf.c	Remove advertising clause from University of California Regent's license,	2004-04-05 21:03:37 +00:00
subr_sleepqueue.c	Close a race between sleepq_broadcast() and sleepq_catch_signals().	2005-04-14 06:30:32 +00:00
subr_smp.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
subr_taskqueue.c	Add taskqueue_drain. This waits for the specified task to finish, if	2004-10-05 04:16:01 +00:00
subr_trap.c	- Rev 1.83 of kern_lock.c fixes the td_locks assert, reenable it here.	2005-03-28 12:52:46 +00:00
subr_turnstile.c	Make a bunch of malloc types static.	2005-02-10 12:02:37 +00:00
subr_unit.c	Remove debugging printfs.	2005-03-14 06:51:29 +00:00
subr_witness.c	The latest release of the FreeBSD driver (twa) for	2005-04-12 22:07:11 +00:00
sys_generic.c	Implement kern_adjtime(), kern_readv(), kern_sched_rr_get_interval(),	2005-03-31 22:51:18 +00:00
sys_pipe.c	Rearrange the kninit calls for both directions of a pipe so that	2005-01-17 07:56:28 +00:00
sys_process.c	Add missing cases for PT_SYSCALL.	2005-03-18 21:22:28 +00:00
sys_socket.c	The SO_NOSIGPIPE socket option allows a user process to mark a socket	2005-03-11 15:06:16 +00:00
syscalls.c	regen	2005-03-01 17:44:34 +00:00
syscalls.master	Fix typo in comment.	2005-03-09 11:50:55 +00:00
sysv_ipc.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
sysv_msg.c	Add much needed descriptions for a number of the IPC related sysctl OIDs.	2005-02-12 01:22:39 +00:00
sysv_sem.c	check copyin return value	2005-03-19 04:34:23 +00:00
sysv_shm.c	Add much needed descriptions for a number of the IPC related sysctl OIDs.	2005-02-12 01:22:39 +00:00
tty.c	According to the comment in struct tty, t_modem is optional; hence we should	2005-04-13 13:56:17 +00:00
tty_compat.c	Put the pre FreeBSD-2.x tty compat code under BURN_BRIDGES.	2004-06-21 22:57:16 +00:00
tty_conf.c	Preparation commit for the tty cleanups that will follow in the near	2004-07-15 20:47:41 +00:00
tty_cons.c	Use dynamic major number allocation for /dev/console, there is no	2005-02-27 21:52:42 +00:00
tty_pty.c	Explicitly hold a reference to the cdev we have just cloned. This	2005-03-31 12:19:44 +00:00
tty_subr.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
tty_tty.c	Explicitly hold a reference to the cdev we have just cloned. This	2005-03-31 12:19:44 +00:00
uipc_accf.c	Move the logic implementing retrieval of the SO_ACCEPTFILTER socket option	2005-03-12 12:57:18 +00:00
uipc_cow.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
uipc_domain.c	/* -> /*- for copyright notices, minor format tweaks as necessary	2005-01-06 23:35:40 +00:00
uipc_mbuf.c	add m_copyup function.. This can be used to help make our ip stack less	2005-03-17 19:34:57 +00:00
uipc_mbuf2.c	Make a bunch of malloc types static.	2005-02-10 12:02:37 +00:00
uipc_proto.c	Remove advertising clause from University of California Regent's license,	2004-04-05 21:03:37 +00:00
uipc_sem.c	Insert missing increment of (i) when walking the temporary semaphore	2005-02-25 21:00:14 +00:00
uipc_sockbuf.c	Extend the coverage of the accept and socket mutexes in soisconnected()	2005-03-12 13:39:39 +00:00
uipc_socket.c	Move the logic implementing retrieval of the SO_ACCEPTFILTER socket option	2005-03-12 12:57:18 +00:00
uipc_socket2.c	Extend the coverage of the accept and socket mutexes in soisconnected()	2005-03-12 13:39:39 +00:00
uipc_syscalls.c	- LK_NOPAUSE is a nop now.	2005-03-31 04:37:09 +00:00
uipc_usrreq.c	Implement unix(4) socket options LOCAL_CREDS and LOCAL_CONNWAIT.	2005-04-13 00:01:46 +00:00
vfs_acl.c	Rename suser_cred()'s PRISON_ROOT flag to SUSER_ALLOWJAIL. This is	2004-07-26 07:24:04 +00:00
vfs_aio.c	fix aio+kq... I've been running ambrisko's test program for much longer	2005-03-18 01:11:39 +00:00
vfs_bio.c	- Add information about the buf lock to db_show_buffer.	2005-03-25 00:20:37 +00:00
vfs_cache.c	- Change all filesystems and vfs_cache to relock the dvp once the child is	2005-04-13 10:59:09 +00:00
vfs_cluster.c	make cluster_callback() static	2005-02-10 12:17:48 +00:00
vfs_default.c	- Now that writes to character devices supporting softupdates can	2005-04-03 10:24:03 +00:00
vfs_export.c	- Pass LK_EXCLUSIVE to VFS_ROOT() to satisfy the new flags argument. For	2005-03-24 07:31:38 +00:00
vfs_extattr.c	- vput(tvp) before vrele(tdvp) in kern_rename() to avoid lock order issues.	2005-04-11 09:19:08 +00:00
vfs_hash.c	Fix bug in vfs_hash_rehash(): use correct bucket. This only affected	2005-04-07 07:54:08 +00:00
vfs_init.c	Remove VFS_START(). Its original purpose involved the mfs filesystem,	2005-02-20 23:02:20 +00:00
vfs_lookup.c	- Remove a debugging printf that slipped in.	2005-04-13 23:36:28 +00:00
vfs_mount.c	- LK_NOPAUSE is a nop now.	2005-03-31 04:37:09 +00:00
vfs_subr.c	- Change vop_lookup_post assertions to reflect recent vfs_lookup changes.	2005-04-13 10:57:53 +00:00
vfs_syscalls.c	- vput(tvp) before vrele(tdvp) in kern_rename() to avoid lock order issues.	2005-04-11 09:19:08 +00:00
vfs_vnops.c	- Assert that we're no longer doing recursive vn_locks in inactive/reclaim	2005-04-11 09:23:56 +00:00
vnode_if.src	- Mark the VOPs that require exclusive locks. Those that aren't marked	2005-04-11 15:19:29 +00:00