mirror of
https://github.com/freebsd/freebsd-src
synced 2024-07-22 02:37:15 +00:00
8ac5aef8f3
This change takes capsicum-test from upstream and applies some local changes to make the
tests work on FreeBSD when executed via Kyua.
The local modifications are as follows:
1. Make `OpenatTest.WithFlag` pass with the new dot-dot lookup behavior in FreeBSD 12.x+.
2. capsicum-test references a set of helper binaries: `mini-me`, `mini-me.noexec`, and
`mini-me.setuid`, as part of the execve/fexecve tests, via execve, fexecve, and open.
It achieves this upstream by assuming `mini-me*` is in the current directory, however,
in order for Kyua to execute `capsicum-test`, it needs to provide a full path to
`mini-me*`. In order to achieve this, I made `capsicum-test` cache the executable's
path from argv[0] in main(..) and use the cached value to compute the path to
`mini-me*` as part of the execve/fexecve testcases.
3. The capsicum-test test suite assumes that it's always being run on CAPABILITIES enabled
kernels. However, there's a chance that the test will be run on a host without a
CAPABILITIES enabled kernel, so we must check for the support before running the tests.
The way to achieve this is to add the relevant `feature_present("security_capabilities")`
check to SetupEnvironment::SetUp() and skip the tests when the support is not available.
While here, add a check for `kern.trap_enotcap` being enabled. As noted by markj@ in
https://github.com/google/capsicum-test/issues/23, this sysctl being enabled can trigger
non-deterministic failures. Therefore, the tests should be skipped if this sysctl is
enabled.
All local changes have been submitted to the capsicum-test project
(https://github.com/google/capsicum-test) and are in various stages of review.
Please see the following pull requests for more details:
1. https://github.com/google/capsicum-test/pull/35
2. https://github.com/google/capsicum-test/pull/41
3. https://github.com/google/capsicum-test/pull/42
Reviewed by: asomers
Discussed with: emaste, markj
Approved by: emaste (mentor)
MFC after: 2 months
Differential Revision: https://reviews.freebsd.org/D19758
176 lines
4.5 KiB
C++
176 lines
4.5 KiB
C++
/*
|
|
* Minimal portability layer for Capsicum-related features.
|
|
*/
|
|
#ifndef __CAPSICUM_H__
|
|
#define __CAPSICUM_H__
|
|
|
|
#ifdef __FreeBSD__
|
|
#include "capsicum-freebsd.h"
|
|
#endif
|
|
|
|
#ifdef __linux__
|
|
#include "capsicum-linux.h"
|
|
#endif
|
|
|
|
/*
|
|
* CAP_ALL/CAP_NONE is a value in FreeBSD9.x Capsicum, but a functional macro
|
|
* in FreeBSD10.x Capsicum. Always use CAP_SET_ALL/CAP_SET_NONE instead.
|
|
*/
|
|
#ifndef CAP_SET_ALL
|
|
#ifdef CAP_RIGHTS_VERSION
|
|
#define CAP_SET_ALL(rights) CAP_ALL(rights)
|
|
#else
|
|
#define CAP_SET_ALL(rights) *(rights) = CAP_MASK_VALID
|
|
#endif
|
|
#endif
|
|
|
|
#ifndef CAP_SET_NONE
|
|
#ifdef CAP_RIGHTS_VERSION
|
|
#define CAP_SET_NONE(rights) CAP_NONE(rights)
|
|
#else
|
|
#define CAP_SET_NONE(rights) *(rights) = 0
|
|
#endif
|
|
#endif
|
|
|
|
|
|
/************************************************************
|
|
* Define new-style rights in terms of old-style rights if
|
|
* absent.
|
|
************************************************************/
|
|
#include "capsicum-rights.h"
|
|
|
|
/*
|
|
* Cope with systems (e.g. FreeBSD 10.x) where CAP_RENAMEAT hasn't been split out.
|
|
* (src, dest): RENAMEAT, LINKAT => RENAMEAT_SOURCE, RENAMEAT_TARGET
|
|
*/
|
|
#ifndef CAP_RENAMEAT_SOURCE
|
|
#define CAP_RENAMEAT_SOURCE CAP_RENAMEAT
|
|
#endif
|
|
#ifndef CAP_RENAMEAT_TARGET
|
|
#define CAP_RENAMEAT_TARGET CAP_LINKAT
|
|
#endif
|
|
/*
|
|
* Cope with systems (e.g. FreeBSD 10.x) where CAP_RENAMEAT hasn't been split out.
|
|
* (src, dest): 0, LINKAT => LINKAT_SOURCE, LINKAT_TARGET
|
|
*/
|
|
#ifndef CAP_LINKAT_SOURCE
|
|
#define CAP_LINKAT_SOURCE CAP_LOOKUP
|
|
#endif
|
|
#ifndef CAP_LINKAT_TARGET
|
|
#define CAP_LINKAT_TARGET CAP_LINKAT
|
|
#endif
|
|
|
|
#ifdef CAP_PREAD
|
|
/* Existence of CAP_PREAD implies new-style CAP_SEEK semantics */
|
|
#define CAP_SEEK_ASWAS 0
|
|
#else
|
|
/* Old-style CAP_SEEK semantics */
|
|
#define CAP_SEEK_ASWAS CAP_SEEK
|
|
#define CAP_PREAD CAP_READ
|
|
#define CAP_PWRITE CAP_WRITE
|
|
#endif
|
|
|
|
#ifndef CAP_MMAP_R
|
|
#define CAP_MMAP_R (CAP_READ|CAP_MMAP)
|
|
#define CAP_MMAP_W (CAP_WRITE|CAP_MMAP)
|
|
#define CAP_MMAP_X (CAP_MAPEXEC|CAP_MMAP)
|
|
#define CAP_MMAP_RW (CAP_MMAP_R|CAP_MMAP_W)
|
|
#define CAP_MMAP_RX (CAP_MMAP_R|CAP_MMAP_X)
|
|
#define CAP_MMAP_WX (CAP_MMAP_W|CAP_MMAP_X)
|
|
#define CAP_MMAP_RWX (CAP_MMAP_R|CAP_MMAP_W|CAP_MMAP_X)
|
|
#endif
|
|
|
|
#ifndef CAP_MKFIFOAT
|
|
#define CAP_MKFIFOAT CAP_MKFIFO
|
|
#endif
|
|
|
|
#ifndef CAP_MKNODAT
|
|
#define CAP_MKNODAT CAP_MKFIFOAT
|
|
#endif
|
|
|
|
#ifndef CAP_MKDIRAT
|
|
#define CAP_MKDIRAT CAP_MKDIR
|
|
#endif
|
|
|
|
#ifndef CAP_UNLINKAT
|
|
#define CAP_UNLINKAT CAP_RMDIR
|
|
#endif
|
|
|
|
#ifndef CAP_SOCK_CLIENT
|
|
#define CAP_SOCK_CLIENT \
|
|
(CAP_CONNECT | CAP_GETPEERNAME | CAP_GETSOCKNAME | CAP_GETSOCKOPT | \
|
|
CAP_PEELOFF | CAP_READ | CAP_WRITE | CAP_SETSOCKOPT | CAP_SHUTDOWN)
|
|
#endif
|
|
|
|
#ifndef CAP_SOCK_SERVER
|
|
#define CAP_SOCK_SERVER \
|
|
(CAP_ACCEPT | CAP_BIND | CAP_GETPEERNAME | CAP_GETSOCKNAME | \
|
|
CAP_GETSOCKOPT | CAP_LISTEN | CAP_PEELOFF | CAP_READ | CAP_WRITE | \
|
|
CAP_SETSOCKOPT | CAP_SHUTDOWN)
|
|
#endif
|
|
|
|
#ifndef CAP_EVENT
|
|
#define CAP_EVENT CAP_POLL_EVENT
|
|
#endif
|
|
|
|
/************************************************************
|
|
* Define new-style API functions in terms of old-style API
|
|
* functions if absent.
|
|
************************************************************/
|
|
#ifndef HAVE_CAP_RIGHTS_GET
|
|
/* Define cap_rights_get() in terms of old-style cap_getrights() */
|
|
inline int cap_rights_get(int fd, cap_rights_t *rights) {
|
|
return cap_getrights(fd, rights);
|
|
}
|
|
#endif
|
|
|
|
#ifndef HAVE_CAP_RIGHTS_LIMIT
|
|
/* Define cap_rights_limit() in terms of old-style cap_new() and dup2() */
|
|
#include <unistd.h>
|
|
inline int cap_rights_limit(int fd, const cap_rights_t *rights) {
|
|
int cap = cap_new(fd, *rights);
|
|
if (cap < 0) return cap;
|
|
int rc = dup2(cap, fd);
|
|
if (rc < 0) return rc;
|
|
close(cap);
|
|
return rc;
|
|
}
|
|
#endif
|
|
|
|
#include <stdio.h>
|
|
#ifdef CAP_RIGHTS_VERSION
|
|
/* New-style Capsicum API extras for debugging */
|
|
static inline void cap_rights_describe(const cap_rights_t *rights, char *buffer) {
|
|
int ii;
|
|
for (ii = 0; ii < (CAP_RIGHTS_VERSION+2); ii++) {
|
|
int len = sprintf(buffer, "0x%016llx ", (unsigned long long)rights->cr_rights[ii]);
|
|
buffer += len;
|
|
}
|
|
}
|
|
|
|
#ifdef __cplusplus
|
|
#include <iostream>
|
|
#include <iomanip>
|
|
inline std::ostream& operator<<(std::ostream& os, cap_rights_t rights) {
|
|
for (int ii = 0; ii < (CAP_RIGHTS_VERSION+2); ii++) {
|
|
os << std::hex << std::setw(16) << std::setfill('0') << (unsigned long long)rights.cr_rights[ii] << " ";
|
|
}
|
|
return os;
|
|
}
|
|
#endif
|
|
|
|
#else
|
|
|
|
static inline void cap_rights_describe(const cap_rights_t *rights, char *buffer) {
|
|
sprintf(buffer, "0x%016llx", (*rights));
|
|
}
|
|
|
|
#endif /* new/old style rights manipulation */
|
|
|
|
#ifdef __cplusplus
|
|
#include <string>
|
|
extern std::string capsicum_test_bindir;
|
|
#endif
|
|
|
|
#endif /*__CAPSICUM_H__*/
|