mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-03 15:15:01 +00:00
fbae308319
Not all of the tree is happy for realinstall to be done in parallel. In particular, Makefile.inc1 uses .WAIT to force etc to be installed after earlier subdirectories, since etc calls into share/man's makedb to run makewhatis on the tree and needs all manpages to have been installed. Also, libexec/Makefile doesn't set SUBDIR_PARALLEL, and the link from ld-elf32.1 to ld-elf.1 relies on rtld-elf having been installed before rtld-elf32, otherwise creating the link will fail. In general, core behavioural differences like this between NO_ROOT and "normal" builds are also dangerous and confusing. If this optimisation is deemed important, it should be reintroduced in a more limited and robust manner that doesn't break the above situations. Until then value correctness over slight efficiency gains on high core count machines, the same machines where you're more likely to encounter issues from this optimisation. This reverts commitscd19ecdbdc("Similar to r296013 for NO_ROOT, force SUBDIR_PARALLEL for buildworld WORLDTMP staging.") andb9c6f31681("Add more STANDALONE_SUBDIR_TARGETS."). Found by: CheriBSD Jenkins Reviewed by: bdrewery, brooks Fixes:cd19ecdbdc("Similar to r296013 for NO_ROOT, force SUBDIR_PARALLEL for buildworld WORLDTMP staging.") Fixes:b9c6f31681("Add more STANDALONE_SUBDIR_TARGETS.") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D43705
210 lines
6 KiB
Makefile
210 lines
6 KiB
Makefile
# The include file <bsd.subdir.mk> contains the default targets
|
|
# for building subdirectories.
|
|
#
|
|
# For all of the directories listed in the variable SUBDIRS, the
|
|
# specified directory will be visited and the target made. There is
|
|
# also a default target which allows the command "make subdir" where
|
|
# subdir is any directory listed in the variable SUBDIRS.
|
|
#
|
|
#
|
|
# +++ variables +++
|
|
#
|
|
# DISTRIBUTION Name of distribution. [base]
|
|
#
|
|
# SUBDIR A list of subdirectories that should be built as well.
|
|
# Each of the targets will execute the same target in the
|
|
# subdirectories. SUBDIR.yes and SUBDIR.yes.yes are
|
|
# automatically appended to this list.
|
|
#
|
|
# +++ targets +++
|
|
#
|
|
# distribute:
|
|
# This is a variant of install, which will
|
|
# put the stuff into the right "distribution".
|
|
#
|
|
# See SUBDIR_TARGETS for list of targets that will recurse.
|
|
#
|
|
# Targets defined in STANDALONE_SUBDIR_TARGETS will always be ran
|
|
# with SUBDIR_PARALLEL and will not respect .WAIT or SUBDIR_DEPEND_
|
|
# values.
|
|
#
|
|
# SUBDIR_TARGETS and STANDALONE_SUBDIR_TARGETS can be appended to
|
|
# via make.conf or src.conf.
|
|
#
|
|
|
|
.if !target(__<bsd.subdir.mk>__)
|
|
__<bsd.subdir.mk>__:
|
|
|
|
.if ${MK_AUTO_OBJ} == "no"
|
|
_obj= obj
|
|
.endif
|
|
|
|
SUBDIR_TARGETS+= \
|
|
all all-man analyze buildconfig buildfiles buildincludes \
|
|
checkdpadd clean cleandepend cleandir cleanilinks \
|
|
cleanobj depend distribute files includes installconfig \
|
|
installdirs \
|
|
installfiles installincludes print-dir realinstall \
|
|
maninstall manlint ${_obj} objlink tags \
|
|
|
|
# Described above.
|
|
STANDALONE_SUBDIR_TARGETS+= \
|
|
all-man buildconfig buildfiles buildincludes check checkdpadd \
|
|
clean cleandepend cleandir cleanilinks cleanobj files includes \
|
|
installconfig installdirs installincludes installfiles print-dir \
|
|
maninstall manlint obj objlink
|
|
|
|
.include <bsd.init.mk>
|
|
|
|
.if ${MK_META_MODE} == "yes"
|
|
.MAKE.JOB.PREFIX=
|
|
ECHODIR= :
|
|
.endif
|
|
|
|
.if make(print-dir)
|
|
NEED_SUBDIR= 1
|
|
ECHODIR= :
|
|
.SILENT:
|
|
.if ${RELDIR:U.} != "."
|
|
print-dir: .PHONY
|
|
@echo ${RELDIR}
|
|
.endif
|
|
.endif
|
|
|
|
.if ${MK_AUTO_OBJ} == "yes" && !target(obj)
|
|
obj: .PHONY
|
|
.endif
|
|
|
|
.if !defined(NEED_SUBDIR)
|
|
# .MAKE.DEPENDFILE==/dev/null is set by bsd.dep.mk to avoid reading
|
|
# Makefile.depend
|
|
.if ${.MAKE.LEVEL} == 0 && ${MK_DIRDEPS_BUILD} == "yes" && !empty(SUBDIR) && \
|
|
${.MAKE.DEPENDFILE} != "/dev/null"
|
|
.include <meta.subdir.mk>
|
|
# ignore this
|
|
_SUBDIR:
|
|
.endif
|
|
.endif
|
|
|
|
DISTRIBUTION?= base
|
|
.if !target(distribute)
|
|
distribute: .MAKE
|
|
.for dist in ${DISTRIBUTION}
|
|
${_+_}cd ${.CURDIR}; \
|
|
${MAKE} install installconfig -DNO_SUBDIR DISTBASE=/${dist} DESTDIR=${DISTDIR}/${dist} SHARED=copies
|
|
.endfor
|
|
.endif
|
|
# Convenience targets to run 'build${target}' and 'install${target}' when
|
|
# calling 'make ${target}'.
|
|
.for __target in files includes
|
|
.if !target(${__target})
|
|
${__target}: build${__target} install${__target}
|
|
.ORDER: build${__target} install${__target}
|
|
.endif
|
|
.endfor
|
|
|
|
# Make 'install' supports a before and after target. Actual install
|
|
# hooks are placed in 'realinstall'.
|
|
.if !target(install)
|
|
.for __stage in before real after
|
|
.if !target(${__stage}install)
|
|
${__stage}install:
|
|
.endif
|
|
.endfor
|
|
install: beforeinstall realinstall afterinstall
|
|
.ORDER: beforeinstall realinstall afterinstall
|
|
.endif
|
|
.ORDER: all install
|
|
|
|
# SUBDIR recursing may be disabled for MK_DIRDEPS_BUILD
|
|
.if !target(_SUBDIR)
|
|
|
|
.if defined(SUBDIR) || defined(SUBDIR.yes) || defined(SUBDIR.yes.yes)
|
|
SUBDIR:=${SUBDIR} ${SUBDIR.yes} ${SUBDIR.yes.yes}
|
|
SUBDIR:=${SUBDIR:u}
|
|
.endif
|
|
|
|
.if defined(SUBDIR.)
|
|
.error ${.CURDIR}: Found variable SUBDIR. with value "${SUBDIR.}". This was \
|
|
probably caused by using SUBDIR.$${MK_FOO} without including \
|
|
<src.opts.mk> or by using an invalid $${MK_FOO} option.
|
|
.endif
|
|
|
|
# Subdir code shared among 'make <subdir>', 'make <target>' and SUBDIR_PARALLEL.
|
|
_SUBDIR_SH= \
|
|
if test -d ${.CURDIR}/$${dir}.${MACHINE_ARCH}; then \
|
|
dir=$${dir}.${MACHINE_ARCH}; \
|
|
fi; \
|
|
${ECHODIR} "===> ${DIRPRFX}$${dir} ($${target})"; \
|
|
cd ${.CURDIR}/$${dir}; \
|
|
${MAKE} $${target} DIRPRFX=${DIRPRFX}$${dir}/
|
|
|
|
# This is kept for compatibility only. The normal handling of attaching to
|
|
# SUBDIR_TARGETS will create a target for each directory.
|
|
_SUBDIR: .USEBEFORE
|
|
.if defined(SUBDIR) && !empty(SUBDIR) && !defined(NO_SUBDIR)
|
|
@${_+_}target=${.TARGET:realinstall=install}; \
|
|
for dir in ${SUBDIR:N.WAIT}; do ( ${_SUBDIR_SH} ); done
|
|
.endif
|
|
|
|
# Create 'make subdir' targets to run the real 'all' target.
|
|
.for __dir in ${SUBDIR:N.WAIT}
|
|
${__dir}: all_subdir_${DIRPRFX}${__dir} .PHONY
|
|
.endfor
|
|
|
|
.for __target in ${SUBDIR_TARGETS}
|
|
# Can ordering be skipped for this and SUBDIR_PARALLEL forced?
|
|
.if ${STANDALONE_SUBDIR_TARGETS:M${__target}}
|
|
_is_standalone_target= 1
|
|
_subdir_filter= N.WAIT
|
|
.else
|
|
_is_standalone_target= 0
|
|
_subdir_filter=
|
|
.endif
|
|
__subdir_targets=
|
|
.for __dir in ${SUBDIR:${_subdir_filter}}
|
|
.if ${__dir} == .WAIT
|
|
__subdir_targets+= .WAIT
|
|
.else
|
|
__deps=
|
|
.if ${_is_standalone_target} == 0
|
|
.if defined(SUBDIR_PARALLEL)
|
|
# Apply SUBDIR_DEPEND dependencies for SUBDIR_PARALLEL.
|
|
.for __dep in ${SUBDIR_DEPEND_${__dir}}
|
|
__deps+= ${__target}_subdir_${DIRPRFX}${__dep}
|
|
.endfor
|
|
.else
|
|
# For non-parallel builds, directories depend on all targets before them.
|
|
__deps:= ${__subdir_targets}
|
|
.endif # defined(SUBDIR_PARALLEL)
|
|
.endif # ${_is_standalone_target} == 0
|
|
${__target}_subdir_${DIRPRFX}${__dir}: .PHONY .MAKE .SILENT ${__deps}
|
|
@${_+_}target=${__target:realinstall=install}; \
|
|
dir=${__dir}; \
|
|
${_SUBDIR_SH};
|
|
__subdir_targets+= ${__target}_subdir_${DIRPRFX}${__dir}
|
|
.endif # ${__dir} == .WAIT
|
|
.endfor # __dir in ${SUBDIR}
|
|
|
|
# Attach the subdir targets to the real target.
|
|
# Only recurse on directly-called targets. I.e., don't recurse on dependencies
|
|
# such as 'install' becoming {before,real,after}install, just recurse
|
|
# 'install'. Despite that, 'realinstall' is special due to ordering issues
|
|
# with 'afterinstall'.
|
|
.if !defined(NO_SUBDIR) && (make(${__target}) || \
|
|
(${__target} == realinstall && make(install)))
|
|
${__target}: ${__subdir_targets} .PHONY
|
|
.endif # make(${__target})
|
|
.endfor # __target in ${SUBDIR_TARGETS}
|
|
|
|
.endif # !target(_SUBDIR)
|
|
|
|
# Ensure all targets exist
|
|
.for __target in ${SUBDIR_TARGETS}
|
|
.if !target(${__target})
|
|
${__target}:
|
|
.endif
|
|
.endfor
|
|
|
|
.endif
|