mirror of
https://github.com/freebsd/freebsd-src
synced 2024-07-21 18:27:22 +00:00
![]() This is a rollup of a lot of changes. In summary, lots of bug fixes, Unicode support and CSV support to match the 2nd Edition of the Awk Book. In detail, from AWK's FIXES and FIXES.1e: From FIXES: Oct 30, 2023: multiple fixes and a minor code cleanup. disabled utf-8 for non-multibyte locales, such as C or POSIX. fixed a bad char * cast that causes incorrect results on big-endian systems. also fixed an out-of-bounds read for empty CCL. fixed a buffer overflow in substr with utf-8 strings. many thanks to Todd C Miller. Sep 24, 2023: fnematch and getrune have been overhauled to solve issues around unicode FS and RS. also fixed gsub null match issue with unicode. big thanks to Arnold Robbins. Sep 12, 2023: Fixed a length error in u8_byte2char that set RSTART to incorrect (cannot happen) value for EOL match(str, /$/). ----------------------------------------------------------------- [This entry is a summary, not a precise list of changes.] Added --csv option to enable processing of comma-separated values inputs. When --csv is enabled, fields are separated by commas, fields may be quoted with " double quotes, fields may contain embedded newlines. If no explicit separator argument is provided, split() uses the setting of --csv to determine how fields are split. Strings may now contain UTF-8 code points (not necessarily characters). Functions that operate on characters, like length, substr, index, match, etc., use UTF-8, so the length of a string of 3 emojis is 3, not 12 as it would be if bytes were counted. Regular expressions are processes as UTF-8. Unicode literals can be written as \u followed by one to eight hexadecimal digits. These may appear in strings and regular expressions. From FIXES.1e: Sep 06, 2023: Fix edge case where FS is changed on commandline. Thanks to Gordon Shephard and Miguel Pineiro Jr. Fix regular expression clobbering in the lexer, where lexer does not make a copy of regexp literals. also makedfa memory leaks have been plugged. Thanks to Miguel Pineiro Jr. Dec 15, 2022: Force hex escapes in strings to be no more than two characters, as they already are in regular expressions. This brings internal consistency, as well as consistency with gawk. Thanks to Arnold Robbins. Sep 12, 2022: adjbuf minlen error (cannot be 0) in cat, resulting in NULL pbuf. discovered by todd miller. also use-after-free issue with tempfree in cat, thanks to Miguel Pineiro Jr and valgrind. Aug 30, 2022: Various leaks and use-after-free issues plugged/fixed. Thanks to Miguel Pineiro Jr. <mpj@pineiro.cc>. May 23, 2022: Memory leak when assigning a string to some of the built-in variables. allocated string erroneously marked DONTFREE. Thanks to Miguel Pineiro Jr. <mpj@pineiro.cc>. Mar 14, 2022: Historic bug: command-line "name=value" assignment had been truncating its entry in ARGV. (circa 1989) Thanks to Miguel Pineiro Jr. <mpj@pineiro.cc>. Mar 3, 2022: Fixed file management memory leak that appears to have been there since the files array was first initialized with stdin, stdout, and stderr (circa 1992). Thanks to Miguel Pineiro Jr. <mpj@pineiro.cc>. December 8, 2021: The error handling in closefile and closeall was mangled. Long standing warnings had been made fatal and some fatal errors went undetected. Thanks to Miguel Pineiro Jr. <mpj@pineiro.cc>. Nov 03, 2021: getline accesses uninitialized data after getrec() returns 0 on EOF and leaves the contents of buf unchanged. Thanks to Volodymyr Gubarkov, and Todd C Miller. Oct 12, 2021: The fix for #83 changed the code to insert 2 chars, but the call to adjbuf just above it only allows for 1 char. This can cause a heap buffer overflow. Sponsored by: Netflix |
||
---|---|---|
.. | ||
a-format.awk | ||
a-format.bad | ||
a-format.ok | ||
concat-assign-same.awk | ||
concat-assign-same.bad | ||
concat-assign-same.ok | ||
decr-NF.awk | ||
decr-NF.bad | ||
decr-NF.ok | ||
fmt-overflow.awk | ||
fmt-overflow.ok | ||
fs-overflow.awk | ||
fs-overflow.ok | ||
getline-corruption.awk | ||
getline-corruption.in | ||
getline-corruption.ok | ||
getline-numeric.awk | ||
getline-numeric.bad | ||
getline-numeric.in | ||
getline-numeric.ok | ||
inf-nan-torture.awk | ||
inf-nan-torture.in | ||
inf-nan-torture.ok | ||
missing-precision.awk | ||
missing-precision.ok | ||
negative-nf.awk | ||
negative-nf.ok | ||
nf-self-assign.awk | ||
nf-self-assign.bad | ||
nf-self-assign.ok | ||
numeric-fs.awk | ||
numeric-fs.ok | ||
numeric-output-seps.awk | ||
numeric-output-seps.bad | ||
numeric-output-seps.ok | ||
numeric-rs.awk | ||
numeric-rs.bad | ||
numeric-rs.ok | ||
numeric-subsep.awk | ||
numeric-subsep.bad | ||
numeric-subsep.ok | ||
ofs-rebuild.awk | ||
ofs-rebuild.bad | ||
ofs-rebuild.ok | ||
pfile-overflow.awk | ||
pfile-overflow.ok | ||
README | ||
REGRESS | ||
rs_underflow.awk | ||
rs_underflow.in | ||
rs_underflow.ok | ||
rstart-rlength.awk | ||
rstart-rlength.ok | ||
space.awk | ||
space.bad | ||
space.ok | ||
split-fs-from-array.awk | ||
split-fs-from-array.ok | ||
string-conv.awk | ||
string-conv.bad | ||
string-conv.ok | ||
subsep-overflow.awk | ||
subsep-overflow.ok | ||
system-status.awk | ||
system-status.bad | ||
system-status.ok | ||
unary-plus.awk | ||
unary-plus.bad | ||
unary-plus.ok | ||
unicode-fs-rs-1.awk | ||
unicode-fs-rs-1.in | ||
unicode-fs-rs-1.ok | ||
unicode-fs-rs-2.awk | ||
unicode-fs-rs-2.in | ||
unicode-fs-rs-2.ok | ||
unicode-null-match.awk | ||
unicode-null-match.bad | ||
unicode-null-match.ok |
List of bugs fixed. 1. ofs-rebuild: OFS value used to rebuild the record was incorrect. Fixed August 19, 2014. Revised fix August 2018. 2. system-status: Instead of a floating-point division by 256, use the wait(2) macros to create a reasonable exit status. Fixed March 12, 2016. 3. space: Use provided xisblank() function instead of ispace() for matching [[:blank:]]. 4. a-format: Add POSIX standard %a and %A to supported formats. Check at runtime that this format is available. 5. decr-NF: Decrementing NF did not change $0. This is a decades-old bug. There are interactions with the old and new value of OFS as well. Most of the fix came from the NetBSD awk. 6. string-conv: String conversions of scalars were sticky. Once a conversion to string happened, even with OFMT, that value was used until a new numeric value was assigned, even if OFMT differed from CONVFMT, and also if CONVFMT changed. 7. unary-plus: Unary plus on a string constant returned the string. Instead, it should convert the value to numeric and give that value. 8. concat-assign-same: Concatenation previously evaluated both sides of the expression before doing its work, which, since assign() evaluates to the cell being assigned to, meant that expressions like "print (a = 1) (a = 2)" would print "22" rather than "12". 9. missing-precision: When using the format string "%*s", the precision argument was used without checking if it was present first. 10. missing-precision: When using the format string "%*s", the precision argument was used without checking if it was present first. 11. fmt-overflow: The buffer used for OFMT/CONVFMT conversions was written to with sprintf(), which meant that some conversions could write past the end. 12. numeric-subsep, numeric-fs, numeric-output-seps, numerics-rs: If SUBSEP, FS, RS, OFS, or ORS were set to a numeric value, then their string values wouldn't always be generated before being needed. 13. subsep-overflow: The length of SUBSEP needs to be rechecked after calling execute(), in case SUBSEP itself has been changed. 14. split-fs-from-array: If the third argument to split() comes from the array passed as the second argument, then split() would previously read from the freed memory and possibly produce incorrect results (depending on the system's malloc()/free() behaviour.) 15. getline-numeric: The `getline xx < file' syntax did not check if values were numeric, in discordance from POSIX. Test case adapted from one posted by Ben Bacarisse <ben.usenet@bsb.me.uk> in comp.lang.awk, January 2019.