mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-19 06:44:31 +00:00
85f190e4d1
Problem: selwakeup required calling pfind which would cause lock order reversals with the allproc_lock and the per-process filedesc lock. Solution: Instead of recording the pid of the select()'ing process into the selinfo structure, actually record a pointer to the thread. To avoid dereferencing a bad address all the selinfo structures that are in use by a thread are kept in a list hung off the thread (protected by sellock). When a selwakeup occurs the selinfo is removed from that threads list, it is also removed on the way out of select or poll where the thread will traverse its list removing all the selinfos from its own list. Problem: Previously the PROC_LOCK was used to provide the mutual exclusion needed to ensure proper locking, this couldn't work because there was a single condvar used for select and poll and condvars can only be used with a single mutex. Solution: Introduce a global mutex 'sellock' which is used to provide mutual exclusion when recording events to wait on as well as performing notification when an event occurs. Interesting note: schedlock is required to manipulate the per-thread TDF_SELECT flag, however if given its own field it would not need schedlock, also because TDF_SELECT is only manipulated under sellock one doesn't actually use schedlock for syncronization, only to protect against corruption. Proc locks are no longer used in select/poll. Portions contributed by: davidc |
||
|---|---|---|
| .. | ||
| bktr_audio.c | ||
| bktr_audio.h | ||
| bktr_card.c | ||
| bktr_card.h | ||
| bktr_core.c | ||
| bktr_core.h | ||
| bktr_i2c.c | ||
| bktr_i2c.h | ||
| bktr_mem.c | ||
| bktr_mem.h | ||
| bktr_os.c | ||
| bktr_os.h | ||
| bktr_reg.h | ||
| bktr_tuner.c | ||
| bktr_tuner.h | ||
| CHANGELOG.TXT | ||
| ioctl_bt848.h | ||
| ioctl_meteor.h | ||