Commit graph

97 commits

Author SHA1 Message Date
Colin Percival 5fe69bb518 Setting a variable to the same value twice doesn't actually make it
more likely to have the right value.  Remove superfluous assignments.

Found by:	LLVM/Clang Static Checker
2008-08-04 06:39:52 +00:00
Colin Percival f9bcf9cabf Mark functions as __dead2 in order to help the LLVM static checker
understand which code paths aren't possible.

This commit eliminates 117 false positive bug reports of the form
"allocate memory; error out if pointer is NULL; use pointer".
2008-08-04 01:25:48 +00:00
Xin LI c1613cd50a Indent the else path, reduce diff against OpenBSD. 2008-07-18 23:35:31 +00:00
Kevin Lo 068d36032a Fix a longstanding bug, from Otto Moerbeck:
if we're reducing a rule that has an empty
right hand side and the yacc stackpointer is pointing at the very
end of the allocated stack, we end up accessing the stack out of
bounds by the implicit $$ = $1 action

Obtained from:	OpenBSD
2008-07-18 15:05:14 +00:00
Ruslan Ermilov 6c7216df78 Sort sections. 2005-01-18 13:43:56 +00:00
Ruslan Ermilov 6a3e8b0adc Mechanically kill hard sentence breaks. 2004-07-02 22:22:35 +00:00
Wes Peters 0d1bf85301 Use getopt instead of hand-rolled argument parsing. Usage remains
the same, no man page changes required.

PR:		bin/48313
Submitted by:	Stefan Farfeleder <stefan@fafoe.dyndns.org>
Reviewed by:	joe@
2004-03-05 01:52:09 +00:00
Chad David c979c169a7 Add __unused to the declaration of yyrcsid in a more portable way.
Discussed with: alfred, bde, jmallett, obrien
2003-02-12 18:03:55 +00:00
Chad David 0b40ce9875 Backout my previous commit as requested. This solution generates
parsers that are non-portable.
2003-02-08 17:23:22 +00:00
Chad David 143c9ae267 Add __unused to the declaration of yyrcsid. 2003-02-07 03:39:27 +00:00
Ruslan Ermilov de95573725 mdoc(7) police: back out unproved changes from previous revision.
Approved by:	re
2002-11-26 15:34:18 +00:00
Philippe Charnier a1843ba8bc Add section number to .Xr directive. 2002-10-16 15:46:43 +00:00
Philippe Charnier 93b0017f88 Replace various spelling with FALLTHROUGH which is lint()able 2002-08-25 13:23:09 +00:00
Robert Drehmel ddd16e87d0 Use the constants from <limits.h> for the sizes of integral C types
rather than defining them ourselves.
2002-06-11 11:27:20 +00:00
Juli Mallett 6fc8ba94c6 Note that this appeared at least as early as PWB UNIX.
Use the literal string 'PWB UNIX', as we still have no .At macro for it.
2002-06-10 22:59:59 +00:00
Ruslan Ermilov df182f6dd1 mdoc(7) police: tidy up the markup. 2002-05-30 06:56:43 +00:00
David E. O'Brien 046eb0421e Restore some of the original variable names, but fix the warnings their
renaming addressed by removing the global variants instead.
2002-04-23 20:30:30 +00:00
Philippe Charnier e8937ba009 Use `The .Nm utility' 2002-04-20 12:18:28 +00:00
Bill Fenner 69b1a0d9c0 mdoc police: use .El to end the list in the ENVIRONMENT section. 2002-04-17 21:34:47 +00:00
David E. O'Brien 17026331d6 Quiet uninitialized warnings. 2002-04-10 03:00:50 +00:00
Ruslan Ermilov c3e3cbe16e No longer needed to #ifdef __FBSDID, this is now handled by Makefile.inc1. 2002-04-09 11:39:05 +00:00
David E. O'Brien dd78e49935 Revert the "tell the program name in diagnostics". What was I thinking??
warnx() already does this for us.
2002-04-05 03:21:41 +00:00
David E. O'Brien 2c7178b5fc Minor reordering of declarations to reduce diffs to OpenBSD/NetBSD. 2002-04-04 22:25:04 +00:00
David E. O'Brien cdef1605ae Allow to compile errorlessly with GCC 3.1. 2002-04-04 22:15:56 +00:00
David E. O'Brien 653bbe6003 Fix signal race.
Use strlen() rather than magic number.
Use _PATH_TMP.

Obtained from:	OpenBSD rev 1.13 (sig race) & rev 1.9 (strlen)
2002-04-04 22:15:13 +00:00
David E. O'Brien 7a285819e3 Revert revision 1.3. This is WARNS=4 clean w/o it and it only increases
the diffs to Open/NetBSD.
2002-04-04 22:10:23 +00:00
David E. O'Brien ff28a75fed Fix style regression introduced in rev 1.11 during a WARNS cleanup. 2002-04-04 21:59:10 +00:00
David E. O'Brien 947ba7d8b9 Add STANDARDS, ENVIRONMENT, and TABLES sections.
Obtained from:	OpenBSD
2002-04-04 21:31:03 +00:00
David E. O'Brien daab8c603e Minor word smithing. 2002-04-04 21:24:19 +00:00
David E. O'Brien a6fc4226b5 Follow suit with OpenBSD and NetBSD and tell the program name in diagnostics. 2002-04-04 21:09:06 +00:00
David E. O'Brien 96b0ad0ef3 Follow suit with OpenBSD and NetBSD and tell the program name in diagnostics. 2002-04-04 20:58:27 +00:00
Warner Losh 3f330d7d1a remove __P 2002-03-22 01:42:45 +00:00
Mark Murray e35f9517d6 Remove NO_WERRORs and WARNS=n's. To be revisited after GCC3. 2002-02-08 23:07:37 +00:00
Mark Murray e1a50fc693 WARNS=2 fix, but do not set this im Makefile, because this ill be the
default for src/usr.bin/
2001-12-11 22:13:02 +00:00
David Malone 9f5b04e925 Style improvements recommended by Bruce as a follow up to some
of the recent WARNS commits. The idea is:

1) FreeBSD id tags should follow vendor tags.
2) Vendor tags should not be compiled (though copyrights probably should).
3) There should be no blank line between including cdefs and __FBSDIF.
2001-12-10 21:13:08 +00:00
Warner Losh bc505f7742 Only use __FBSDID if it is defined. This fixes the 4.4-release (but
not stable) -> current upgrade path.

Reviewed by: markm
2001-12-08 02:28:16 +00:00
Mark Murray f1b6a5418e Use __FBSDID(). 2001-12-02 21:24:03 +00:00
Mark Murray f906e265a6 WARNS=2 and s/register//.
Set NO_WERROR=true because there are some flex(1) issues that need
to be dealt with.
2001-12-01 17:34:42 +00:00
David E. O'Brien 1c68ec0191 Properly static'ize increase_maxtable().
Submitted by:	db@db.net
2001-10-05 03:02:04 +00:00
David E. O'Brien 2780cd8718 Fix the output so it really does dynamically resize the table.
Submitted by:	Diane Bruce <db@db.net>
2001-10-05 02:09:43 +00:00
David E. O'Brien 1dce684051 Increase the table size by an order of magnitude.
The previous version was too small and YACC core dumped on the during the
hybrid-7 build.

Submitted by:	Diane Bruce <db@db.net>
2001-10-05 00:46:22 +00:00
Ruslan Ermilov 625003720a mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 14:16:33 +00:00
Ruslan Ermilov b9ad8c8635 beforeinstall -> SCRIPTS. 2001-04-07 11:21:35 +00:00
Ruslan Ermilov dc12be5258 MAN[1-9] -> MAN. 2001-03-27 10:52:19 +00:00
Peter Wemm 8d03543c79 Have yacc use a prototype for yygrowstack(void) on ANSI compilers.
This fixes a gcc warning with -Wmissing-prototypes.
2001-02-19 01:10:01 +00:00
Kris Kennaway cca0db7e7e Constify 2000-11-26 11:07:45 +00:00
Nick Hibma c613a5e7dc Fix breakage introduced in rev.1.7. yystacksize and yysslim are global and
should be prefixed by YYPREFIX as well.

Only relevant if -p <yyprefix> is used. Used in cases where multiple parsers
are used in executable.
2000-09-07 15:01:18 +00:00
Bruce Evans 87be6e697a Fixed breakage of K&R support in rev.1.26. yyparse() was defined as
`int yyparse(;) ; { ... }' in K&R mode.  Getting rid of the second
unwanted semicolon in this made the ifdef tangle more tangled than
before.  Fixed a backwards comment in the tangle.
2000-01-17 02:04:06 +00:00
Bruce Evans dd079f6ca5 Fixed breakage of K&R support in rev.1.8 of output.c: don't generate
#elif.  Cleaned up rev.1.8 a bit more: generate the #include of
<stdio.h> closer to the code that needs it.
2000-01-17 01:51:29 +00:00
Kris Kennaway af98c2e2cf malloc more space for temp file name
Noticed by:	marcel
2000-01-10 20:26:24 +00:00