From ff7ad950bebb78348eaecc33abcb978a08038c44 Mon Sep 17 00:00:00 2001 From: Andrew Thompson Date: Thu, 13 May 2010 02:03:00 +0000 Subject: [PATCH] Use fixed width integer types for parsing the binary hid data. PR: usb/146367 Submitted by: Hans Petter Selasky --- lib/libusbhid/data.c | 9 ++++++--- lib/libusbhid/usbhid.h | 6 +++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/libusbhid/data.c b/lib/libusbhid/data.c index afc5a211ddc0..3b90ac6f9560 100644 --- a/lib/libusbhid/data.c +++ b/lib/libusbhid/data.c @@ -34,7 +34,7 @@ __FBSDID("$FreeBSD$"); #include #include "usbhid.h" -int +int32_t hid_get_data(const void *p, const hid_item_t *h) { const uint8_t *buf; @@ -78,12 +78,15 @@ hid_get_data(const void *p, const hid_item_t *h) } void -hid_set_data(void *p, const hid_item_t *h, int data) +hid_set_data(void *p, const hid_item_t *h, int32_t data) { uint8_t *buf; uint32_t hpos; uint32_t hsize; - int i, end, offs, mask; + uint32_t mask; + int i; + int end; + int offs; buf = p; diff --git a/lib/libusbhid/usbhid.h b/lib/libusbhid/usbhid.h index d1d3bf0ebbd0..5e098eabad09 100644 --- a/lib/libusbhid/usbhid.h +++ b/lib/libusbhid/usbhid.h @@ -29,7 +29,7 @@ * */ -#include +#include typedef struct report_desc *report_desc_t; @@ -102,7 +102,7 @@ int hid_parse_usage_in_page(const char *name); int hid_parse_usage_page(const char *name); /* Extracting/insertion of data, data.c: */ -int hid_get_data(const void *p, const hid_item_t *h); -void hid_set_data(void *p, const hid_item_t *h, int data); +int32_t hid_get_data(const void *p, const hid_item_t *h); +void hid_set_data(void *p, const hid_item_t *h, int32_t data); __END_DECLS