system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-09-21 09:13:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Include "opt_kbd.h" since certain structures size depend on the value

Browse source 
of KBDIO_DEBUG which may be defined in the kernel config (as it is in NOTES).

This kind of bug is a _really_ horribly thing as we end up with one bit
of code thinking a particular structure is 136 bytes and another that it
is only 112 bytes.

Ideally all places would remember to #include the right "opt_foo.h" file,
but I think in practice file containing the variable sized struct should
#include it explicitly as a precaution.

Detected by:	FlexeLint
This commit is contained in:
Poul-Henning Kamp 2002-10-15 21:35:01 +00:00
parent 02fcfac0ad
commit fb9da1ef43
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=105181
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sys/dev/atkbdc/atkbdcreg.h
View file

@ -34,6 +34,8 @@
#ifndef _DEV_KBD_ATKBDCREG_H_
#define _DEV_KBD_ATKBDCREG_H_
#include "opt_kbd.h" /* Structures depend on the value if KBDIO_DEBUG */
/* constants */
/* I/O ports */

2
sys/dev/kbd/atkbdcreg.h
View file

@ -34,6 +34,8 @@
#ifndef _DEV_KBD_ATKBDCREG_H_
#define _DEV_KBD_ATKBDCREG_H_
#include "opt_kbd.h" /* Structures depend on the value if KBDIO_DEBUG */
/* constants */
/* I/O ports */