system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-10-17 05:43:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

wordexp(): Avoid leaking the pipe file descriptors to a parallel fork/exec.

Browse source 
This uses the new pipe2() system call added on May 1 (r250159).
This commit is contained in:
Jilles Tjoelker 2013-08-27 21:47:01 +00:00
parent e43ab9b98e
commit f6d7148dc3
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=254977
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/libc/gen/wordexp.c
View file

@ -121,7 +121,7 @@ we_askshell(const char *words, wordexp_t *we, int flags)
serrno = errno;
if (pipe(pdes) < 0)
if (pipe2(pdes, O_CLOEXEC) < 0)
return (WRDE_NOSPACE); /* XXX */
(void)sigemptyset(&newsigblock);
(void)sigaddset(&newsigblock, SIGCHLD);
@ -140,10 +140,10 @@ we_askshell(const char *words, wordexp_t *we, int flags)
* builtin on `words'.
*/
(void)_sigprocmask(SIG_SETMASK, &oldsigblock, NULL);
_close(pdes[0]);
if (_dup2(pdes[1], STDOUT_FILENO) < 0)
if ((pdes[1] != STDOUT_FILENO ?
_dup2(pdes[1], STDOUT_FILENO) :
_fcntl(pdes[1], F_SETFD, 0)) < 0)
_exit(1);
_close(pdes[1]);
execl(_PATH_BSHELL, "sh", flags & WRDE_UNDEF ? "-u" : "+u",
"-c", "eval \"$1\";eval \"wordexp $2\"", "",
flags & WRDE_SHOWERR ? "" : "exec 2>/dev/null", words,