mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-15 04:43:53 +00:00
smartpqi: Change alignment for dma tags
Problem: Under certain I/O conditions, a program doing large block disk reads can cause a controller to crash. Root Cause: The SCSI read request and destination address in the BDMA descriptor is incorrect, causing the BDMA engine in the controller to assert. Fix: Change the alignment for creating bus_dma_tags in the driver from PAGE_SIZE (4k) to 1, which allows the controller to manage it's own address range for BDMA transactions. Risk: Medium Exposure: This reverts a change first made to support NVMe drives on Excalibur. At that time a 4k alignment was necessary. This no longer seems to be the case. PR: 259541 Reported by: Ka Ho Ng <khng@freebsd.org> Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D41619
This commit is contained in:
parent
b064a4c9ee
commit
f07b267d8c
|
@ -629,8 +629,8 @@ smartpqi_attach(device_t dev)
|
||||||
* Create DMA tag for mapping buffers into controller-addressable space.
|
* Create DMA tag for mapping buffers into controller-addressable space.
|
||||||
*/
|
*/
|
||||||
if (bus_dma_tag_create(softs->os_specific.pqi_parent_dmat,/* parent */
|
if (bus_dma_tag_create(softs->os_specific.pqi_parent_dmat,/* parent */
|
||||||
PAGE_SIZE, 0, /* algnmnt, boundary */
|
1, 0, /* algnmnt, boundary */
|
||||||
BUS_SPACE_MAXADDR,/* lowaddr */
|
BUS_SPACE_MAXADDR, /* lowaddr */
|
||||||
BUS_SPACE_MAXADDR, /* highaddr */
|
BUS_SPACE_MAXADDR, /* highaddr */
|
||||||
NULL, NULL, /* filter, filterarg */
|
NULL, NULL, /* filter, filterarg */
|
||||||
(bus_size_t)softs->pqi_cap.max_sg_elem*PAGE_SIZE,/* maxsize */
|
(bus_size_t)softs->pqi_cap.max_sg_elem*PAGE_SIZE,/* maxsize */
|
||||||
|
|
Loading…
Reference in a new issue