system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-21 18:27:22 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

libbsnmptools: Fully comment out set but unused count variable.

Browse source 
These functions all end with 'return (2/* count */);'.

Reviewed by:	emaste
Differential Revision:	https://reviews.freebsd.org/D40670
This commit is contained in:
John Baldwin 2023-06-27 10:19:32 -07:00
parent 1e80d4b188
commit eca9714e4b
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c
View file

@ -483,7 +483,7 @@ parse_ascii(char *ascii, uint8_t *binstr, size_t binlen)
int32_t
parse_authentication(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
{
int32_t count, subopt;
int32_t /* count, */ subopt;
char *val, *option;
const char *const subopts[] = {
"proto",
@ -492,7 +492,7 @@ parse_authentication(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
};
assert(opt_arg != NULL);
count = 1;
/* count = 1; */
while ((subopt = getsubopt1(&opt_arg, subopts, &val, &option)) != EOF) {
switch (subopt) {
case 0:
@ -530,7 +530,7 @@ parse_authentication(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
warnx("Unknown suboption - '%s'", suboptarg);
return (-1);
}
count += 1;
/* count += 1; */
}
return (2/* count */);
}
@ -538,7 +538,7 @@ parse_authentication(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
int32_t
parse_privacy(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
{
int32_t count, subopt;
int32_t /* count, */ subopt;
char *val, *option;
const char *const subopts[] = {
"proto",
@ -547,7 +547,7 @@ parse_privacy(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
};
assert(opt_arg != NULL);
count = 1;
/* count = 1; */
while ((subopt = getsubopt1(&opt_arg, subopts, &val, &option)) != EOF) {
switch (subopt) {
case 0:
@ -583,7 +583,7 @@ parse_privacy(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
warnx("Unknown suboption - '%s'", suboptarg);
return (-1);
}
count += 1;
/* count += 1; */
}
return (2/* count */);
}
@ -591,7 +591,7 @@ parse_privacy(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
int32_t
parse_context(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
{
int32_t count, subopt;
int32_t /* count, */ subopt;
char *val, *option;
const char *const subopts[] = {
"context",
@ -600,7 +600,7 @@ parse_context(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
};
assert(opt_arg != NULL);
count = 1;
/* count = 1; */
while ((subopt = getsubopt1(&opt_arg, subopts, &val, &option)) != EOF) {
switch (subopt) {
case 0:
@ -625,7 +625,7 @@ parse_context(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
warnx("Unknown suboption - '%s'", suboptarg);
return (-1);
}
count += 1;
/* count += 1; */
}
return (2/* count */);
}
@ -633,7 +633,7 @@ parse_context(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
int32_t
parse_user_security(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
{
int32_t count, subopt, saved_errno;
int32_t /* count, */ subopt, saved_errno;
char *val, *option;
const char *const subopts[] = {
"engine",
@ -644,7 +644,7 @@ parse_user_security(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
};
assert(opt_arg != NULL);
count = 1;
/* count = 1; */
while ((subopt = getsubopt1(&opt_arg, subopts, &val, &option)) != EOF) {
switch (subopt) {
case 0:
@ -697,7 +697,7 @@ parse_user_security(struct snmp_toolinfo *snmptoolctx __unused, char *opt_arg)
warnx("Unknown suboption - '%s'", suboptarg);
return (-1);
}
count += 1;
/* count += 1; */
}
return (2/* count */);
}