system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 02:37:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

getty: Avoid NULL deref if stdin is not a tty.

Browse source 
Sponsored by:	Klara, Inc.
Obtained from:	Apple OSS Distributions
Differential Revision: https://reviews.freebsd.org/D37265
This commit is contained in:
Dag-Erling Smørgrav 2022-11-04 15:43:06 +01:00
parent f285f41498
commit eb4d86d529
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
libexec/getty/main.c
View file

@ -212,9 +212,14 @@ main(int argc, char *argv[])
* that the file descriptors are already set up for us.
* J. Gettys - MIT Project Athena.
*/
if (argc <= 2 || strcmp(argv[2], "-") == 0)
snprintf(ttyn, sizeof(ttyn), "%s", ttyname(STDIN_FILENO));
else {
if (argc <= 2 || strcmp(argv[2], "-") == 0) {
char *n = ttyname(STDIN_FILENO);
if (n == NULL) {
syslog(LOG_ERR, "ttyname: %m");
exit(1);
}
snprintf(ttyn, sizeof(ttyn), "%s", n);
} else {
snprintf(ttyn, sizeof(ttyn), "%s%s", _PATH_DEV, argv[2]);
if (strcmp(argv[0], "+") != 0) {
chown(ttyn, 0, 0);