Fsck would find, report, and offer to fix inode check-hash failures.

If requested to fix the inode check-hash it would confirm having done
it, but then fail to make the fix. The same code is used in fsdb which,
unlike fsck, would actually fix the inode check-hash.

The discrepancy occurred because fsck has two ways to fetch inodes.
The inode by number function ginode() and the streaming inode
function getnextinode() used during pass1. Fsdb uses the ginode()
function which correctly does the fix, while fsck first encounters
the bad inode check-hash in pass1 where it is using the getnextinode()
function that failed to make the correction. This patch corrects
the getnextinode() function so that fsck now correctly fixes inodes
with incorrect inode check-hashs.

Reported by:  Gary Jennejohn <gljennjohn@gmail.com>
Sponsored by: Netflix
This commit is contained in:
Kirk McKusick 2018-12-15 17:32:47 +00:00
parent 51e712f865
commit e155208020
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=342128

View file

@ -309,6 +309,8 @@ ginode(ino_t inumber)
if (preen || reply("FIX") != 0) {
if (preen)
printf(" (FIXED)\n");
ffs_update_dinode_ckhash(&sblock,
(struct ufs2_dinode *)dp);
inodirty(dp);
}
}