system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-01 07:55:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

libjail: Guard against programmer error in jailparam_export()

Browse Source 
If the caller didn't use jailparam_import() to fetch the parameter
value, an attempt to export it will trigger a segfault.  Make it a bit
easier to figure out what's happening in this situation.

PR:		276809
Reviewed by:	jamie
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D43732
This commit is contained in:
Mark Johnston 2024-02-03 21:22:09 -05:00
parent 064fa628ce
commit dfabf3efaa
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/libjail/jail.c
View File

@ -737,6 +737,12 @@ jailparam_export(struct jailparam *jp)
int i, nval, ival;
char valbuf[INET6_ADDRSTRLEN];
if (jp->jp_value == NULL) {
snprintf(jail_errmsg, JAIL_ERRMSGLEN,
"parameter %s was not imported", jp->jp_name);
errno = EINVAL;
return (NULL);
}
if ((jp->jp_ctltype & CTLTYPE) == CTLTYPE_STRING) {
value = strdup(jp->jp_value);
if (value == NULL)