system/freebsd-src
system/freebsd-src
1
0
Fork 0
mirror of https://github.com/freebsd/freebsd-src synced 2024-07-22 02:37:15 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

nvme: Give up when we've failed

Browse source 
Normally, we poll the device every so often to see if commands have
timed out. However, we'll go into the recovery state as part of failing
the drive. To account for all possibilties, if we're failed when we get
into the polling function, just stop polling: Party is over.

Sponsored by:		Netflix
This commit is contained in:
Warner Losh 2023-09-15 10:02:32 -06:00
parent 4ff9d27089
commit d95431624f
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
sys/dev/nvme/nvme_qpair.c
View file

@ -1011,6 +1011,17 @@ nvme_qpair_timeout(void *arg)
mtx_assert(&qpair->recovery, MA_OWNED);
/*
* If the controller has failed, give up. We're never going to change
* state from a failed controller: no further transactions are possible.
* We go ahead and let the timeout expire in many cases for simplicity.
*/
if (qpair->ctrlr->is_failed) {
nvme_printf(ctrlr, "Controller failed, giving up\n");
qpair->timer_armed = false;
return;
}
switch (qpair->recovery_state) {
case RECOVERY_NONE:
/*
@ -1094,8 +1105,8 @@ nvme_qpair_timeout(void *arg)
idle = false; /* We want to keep polling */
break;
case RECOVERY_WAITING:
nvme_printf(ctrlr, "waiting for reset to complete\n");
idle = false; /* We want to keep polling */
nvme_printf(ctrlr, "Waiting for reset to complete\n");
idle = false; /* We want to keep polling */
break;
}