mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-06 16:40:47 +00:00
makefs: Plug a memory leak
nvlist_find_string() would return a copy of the found value, but callers assumed they would have to make their own copy. It's simpler to change nvlist_find_string() than it is to change callers, so do that. Reported by: Coverity
This commit is contained in:
parent
47218e711e
commit
d7eec79b70
|
@ -75,10 +75,8 @@ nvlist_find_string(nvlist_t *nvl, const char *key, char **retp)
|
|||
int error, len;
|
||||
|
||||
error = nvlist_find(nvl, key, DATA_TYPE_STRING, NULL, &str, &len);
|
||||
if (error == 0) {
|
||||
*retp = ecalloc(1, len + 1);
|
||||
memcpy(*retp, str, len);
|
||||
}
|
||||
if (error == 0)
|
||||
*retp = str;
|
||||
return (error);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue