mirror of
https://github.com/freebsd/freebsd-src
synced 2024-10-15 21:05:08 +00:00
cxgbe(4): Do not issue an L1CFG command from a VF.
It is pointless to attempt an operation that is not permitted. It spams the firmware devlog with "insufficient caps" errors that distract from real errors. 78 2463625358 ERR CORE insufficient caps to process mailbox cmd: pfn 0x0 vfn 0x1; r_caps 0x86 wx_caps 0x82 required r_caps 0x81 w_caps 0x5 MFC after: 1 week Sponsored by: Chelsio Communications
This commit is contained in:
parent
d0fdafdb0e
commit
d72db09005
|
@ -6023,25 +6023,27 @@ apply_link_config(struct port_info *pi)
|
||||||
if (lc->requested_fec & FEC_BASER_RS)
|
if (lc->requested_fec & FEC_BASER_RS)
|
||||||
MPASS(lc->pcaps & FW_PORT_CAP32_FEC_BASER_RS);
|
MPASS(lc->pcaps & FW_PORT_CAP32_FEC_BASER_RS);
|
||||||
#endif
|
#endif
|
||||||
rc = -t4_link_l1cfg(sc, sc->mbox, pi->tx_chan, lc);
|
if (!(sc->flags & IS_VF)) {
|
||||||
if (rc != 0) {
|
rc = -t4_link_l1cfg(sc, sc->mbox, pi->tx_chan, lc);
|
||||||
/* Don't complain if the VF driver gets back an EPERM. */
|
if (rc != 0) {
|
||||||
if (!(sc->flags & IS_VF) || rc != FW_EPERM)
|
|
||||||
device_printf(pi->dev, "l1cfg failed: %d\n", rc);
|
device_printf(pi->dev, "l1cfg failed: %d\n", rc);
|
||||||
} else {
|
return (rc);
|
||||||
/*
|
}
|
||||||
* An L1_CFG will almost always result in a link-change event if
|
|
||||||
* the link is up, and the driver will refresh the actual
|
|
||||||
* fec/fc/etc. when the notification is processed. If the link
|
|
||||||
* is down then the actual settings are meaningless.
|
|
||||||
*
|
|
||||||
* This takes care of the case where a change in the L1 settings
|
|
||||||
* may not result in a notification.
|
|
||||||
*/
|
|
||||||
if (lc->link_ok && !(lc->requested_fc & PAUSE_AUTONEG))
|
|
||||||
lc->fc = lc->requested_fc & (PAUSE_TX | PAUSE_RX);
|
|
||||||
}
|
}
|
||||||
return (rc);
|
|
||||||
|
/*
|
||||||
|
* An L1_CFG will almost always result in a link-change event if the
|
||||||
|
* link is up, and the driver will refresh the actual fec/fc/etc. when
|
||||||
|
* the notification is processed. If the link is down then the actual
|
||||||
|
* settings are meaningless.
|
||||||
|
*
|
||||||
|
* This takes care of the case where a change in the L1 settings may not
|
||||||
|
* result in a notification.
|
||||||
|
*/
|
||||||
|
if (lc->link_ok && !(lc->requested_fc & PAUSE_AUTONEG))
|
||||||
|
lc->fc = lc->requested_fc & (PAUSE_TX | PAUSE_RX);
|
||||||
|
|
||||||
|
return (0);
|
||||||
}
|
}
|
||||||
|
|
||||||
#define FW_MAC_EXACT_CHUNK 7
|
#define FW_MAC_EXACT_CHUNK 7
|
||||||
|
|
Loading…
Reference in a new issue